From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2FCBB6EC58; Thu, 27 May 2021 14:02:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FCBB6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622113352; bh=Ll+B9qpdiXHU7CCUUKKh9ay/luoQB4mNInr5JOW4o/c=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=WhKY0l6xdqUiok7NVv2yLfidGnX1gWWD63rfcksvwg5tXrxPGOotBJkLQ539RaP/v 33GtVhJvxvVLuOiGPAAWae8rGMvFDY4KA3rSYdpqiMd7hvdwHWtxJ9d30nxtiZAOdh Uk3aOJ8PqOCbEqGtb2PArbK1+2aHD+l01+IEg0fY= Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1EC7B6EC58 for ; Thu, 27 May 2021 14:02:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1EC7B6EC58 Received: by mail-lj1-f182.google.com with SMTP id w7so223150lji.6 for ; Thu, 27 May 2021 04:02:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NaKfYP9CWvCq4M1RZKW+jgl1VWLPgZZ0pXvEboY2hmQ=; b=lpiCL48+EZadQSwrjc87m10TrkGSKNrX0jKxs817BD05Jz+JiJ066Yxnw5wAuSxev9 6vfIbqoCAs3VivrCxZcLKrj7/AViCSGSnbMnx6jLtCy8K7cYXNmoco+7hU0ydCJI421A 7K/dyDStLTjZTZc8TluAb8izeI1XjRlePej8a3cONM7/YE59SB3upLC0B6gr25X8r6vm 2TY+pADCZ3IhZo5Tb5jlHhpNIaf3pbAwWRVci7ZGNcxRVEHOmbSCk20BGDYy/dic4aIJ hBPOkmHlxLvuXszpSJ90Z5X48ofbhioQ5/Lfaqu0la80gKGaK3QBnhJqoPgGp0Y9sNKJ D/9Q== X-Gm-Message-State: AOAM531xhfzDg/Z2xBqTNHjpuGnlaa91dUqX1yzLLMrdL+hSWuR6DdPm mDD4flQqfEiUebGbkUkpfPLG8IR3FXs= X-Google-Smtp-Source: ABdhPJwoXWMKTJexnSFOuXx/mXyG/j7Olx+GyIds9htWmjc00XqTojn2iczep32U4Isv/H+ltX2WtA== X-Received: by 2002:a2e:a0c7:: with SMTP id f7mr2115158ljm.13.1622113349084; Thu, 27 May 2021 04:02:29 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id u14sm170573lft.164.2021.05.27.04.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 04:02:27 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 1FC105A0042; Thu, 27 May 2021 14:02:27 +0300 (MSK) Date: Thu, 27 May 2021 14:02:27 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: <913a4471008f32c4f9448f25ae54c3de6ee2f249.1621935783.git.sergepetrenko@tarantool.org> <0ab586a8-bb17-6e18-b486-c4dd5a0de42c@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ab586a8-bb17-6e18-b486-c4dd5a0de42c@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v2 1/2] box: refactor in_promote using a guard X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, May 27, 2021 at 01:57:19PM +0300, Serge Petrenko wrote: > > Thanks for the review! > I think this piece of code is unrelated to what I'm changing. > This commit was introduced to avoid multiple additions > of `in_promote = false;` in the next commit. > > The change you propose is good, but it's out of scope of this patchset IMO. > I may change apply it though if you insist. OK, lets leave it as is. No need for more patching.