From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification
Date: Tue, 11 May 2021 00:58:33 +0300 [thread overview]
Message-ID: <YJmsibnMtXd8ghmD@grain> (raw)
In-Reply-To: <25ed7418-5dfa-1650-ee92-94dc644a7934@tarantool.org>
On Mon, May 10, 2021 at 08:40:34PM +0200, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> On 04.05.2021 17:58, Cyrill Gorcunov wrote:
> > The position of first argument to check from is 6, not 0.
> > Looks like our tests with CFORMAT was simply not working
> > since commit 7d12d66e67a1ce843a2712980f4d3ba04bc0d4f2.
>
> Please, in addition to the hash add the commit title in
> parentheses.
> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
Updated, thanks! I force pushed all updates.
next prev parent reply other threads:[~2021-05-10 21:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 15:58 [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 01/10] fiber: use uint64_t for fiber IDs Cyrill Gorcunov via Tarantool-patches
2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-10 21:40 ` Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 02/10] popen: fix say_x format arguments Cyrill Gorcunov via Tarantool-patches
2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-10 21:41 ` Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 03/10] raft: fix say_x arguments Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 04/10] box/error: fix argument for CustomError Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 05/10] xlog: fix say_x format Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 06/10] box/vynil: " Cyrill Gorcunov via Tarantool-patches
2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-10 21:51 ` Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 07/10] txn: " Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 08/10] limbo: " Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 09/10] wal: " Cyrill Gorcunov via Tarantool-patches
2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-10 21:55 ` Cyrill Gorcunov via Tarantool-patches
2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification Cyrill Gorcunov via Tarantool-patches
2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-10 21:58 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-05-11 20:13 ` [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers Vladislav Shpilevoy via Tarantool-patches
2021-05-11 21:15 ` Cyrill Gorcunov via Tarantool-patches
2021-05-11 21:24 ` Cyrill Gorcunov via Tarantool-patches
2021-05-12 18:41 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-13 8:17 ` Cyrill Gorcunov via Tarantool-patches
2021-05-13 11:17 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-13 11:44 ` Cyrill Gorcunov via Tarantool-patches
2021-05-13 12:09 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-14 7:56 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJmsibnMtXd8ghmD@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox