From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 2/2] fiber: fiber_join -- don't crash on misuse Date: Thu, 29 Apr 2021 23:39:30 +0300 [thread overview] Message-ID: <YIsZgts/pDuNQmE1@grain> (raw) In-Reply-To: <76ab28d4-6556-9368-7219-8dc0c40dccc4@tarantool.org> On Thu, Apr 29, 2021 at 09:37:56PM +0200, Vladislav Shpilevoy wrote: > > +* Fixed lack of testing for non noinable fibers in `fiber_join()` call. > > + This could lead to unpredictable results. Note the issue affects C > > + level only, in Lua interface `fiber::join()`` the protection is > > fiber::join() -> fiber:join() > > And `` -> ` in the end. Force pushed an update. Thanks! branch gorcunov/gh-6046-fiber-join-3 --- changelogs/unreleased/gh-6046-fiber-join-misuse.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/unreleased/gh-6046-fiber-join-misuse.md b/changelogs/unreleased/gh-6046-fiber-join-misuse.md index 32c15566d..4515d96a8 100644 --- a/changelogs/unreleased/gh-6046-fiber-join-misuse.md +++ b/changelogs/unreleased/gh-6046-fiber-join-misuse.md @@ -2,5 +2,5 @@ * Fixed lack of testing for non noinable fibers in `fiber_join()` call. This could lead to unpredictable results. Note the issue affects C - level only, in Lua interface `fiber::join()`` the protection is + level only, in Lua interface `fiber:join()` the protection is turned on already. -- 2.30.2
next prev parent reply other threads:[~2021-04-29 20:39 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-28 10:22 [Tarantool-patches] [PATCH v2 0/2] fiber: prevent fiber_join from misuse Cyrill Gorcunov via Tarantool-patches 2021-04-28 10:22 ` [Tarantool-patches] [PATCH v2 1/2] fiber: fiber_join -- drop redundat variable Cyrill Gorcunov via Tarantool-patches 2021-04-28 15:13 ` Serge Petrenko via Tarantool-patches 2021-04-28 10:22 ` [Tarantool-patches] [PATCH v2 2/2] fiber: fiber_join -- don't crash on misuse Cyrill Gorcunov via Tarantool-patches 2021-04-28 15:13 ` Serge Petrenko via Tarantool-patches 2021-04-28 15:21 ` Cyrill Gorcunov via Tarantool-patches 2021-04-28 15:34 ` Serge Petrenko via Tarantool-patches 2021-04-28 21:16 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-28 22:12 ` Cyrill Gorcunov via Tarantool-patches 2021-04-29 11:10 ` [Tarantool-patches] [PATCH v3 " Cyrill Gorcunov via Tarantool-patches 2021-04-29 19:37 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-29 20:39 ` Cyrill Gorcunov via Tarantool-patches [this message] 2021-04-29 21:10 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-30 8:13 ` [Tarantool-patches] [PATCH v2 0/2] fiber: prevent fiber_join from misuse Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YIsZgts/pDuNQmE1@grain \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 2/2] fiber: fiber_join -- don'\''t crash on misuse' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox