From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode
Date: Sun, 25 Apr 2021 16:26:57 +0300 [thread overview]
Message-ID: <YIVuIe9J4rbZzZSC@grain> (raw)
In-Reply-To: <48231b42-debd-ac18-2a97-bbfa9b4aec5b@tarantool.org>
On Sun, Apr 25, 2021 at 11:08:25AM +0300, Serge Petrenko wrote:
> > +enum wal_mode {
> > + /**
> > + * Do not write data at all.
> > + */
> > + WAL_NONE,
> > +
...
> Thanks for the patch!
>
> I'd leave an explicit WAL_NONE = 0.
> I didn't know that enums start at zero, TBH.
Yeah, this is a part of language standart.
> This would be more readable IMO.
I'll make it so and force push. Thanks a huge for review, guys!
next prev parent reply other threads:[~2021-04-25 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 8:37 [Tarantool-patches] [PATCH 0/3] wal,txn_limbo: a few cleanups Cyrill Gorcunov via Tarantool-patches
2021-04-19 8:37 ` [Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode Cyrill Gorcunov via Tarantool-patches
2021-04-23 20:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-23 21:17 ` Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:08 ` Serge Petrenko via Tarantool-patches
2021-04-25 13:26 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-04-26 9:40 ` Serge Petrenko via Tarantool-patches
2021-04-26 9:58 ` Cyrill Gorcunov via Tarantool-patches
2021-04-19 8:37 ` [Tarantool-patches] [PATCH 2/3] txn_limbo: simplify owner migration condition Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:09 ` Serge Petrenko via Tarantool-patches
2021-04-19 8:37 ` [Tarantool-patches] [PATCH 3/3] txn_limbo: simplify txn_limbo_ack Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:11 ` Serge Petrenko via Tarantool-patches
2021-04-22 11:34 ` [Tarantool-patches] [PATCH 4/4] txn_limbo: simplify txn_limbo_on_parameters_change Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:13 ` Serge Petrenko via Tarantool-patches
2021-04-25 13:18 ` [Tarantool-patches] [PATCH 0/3] wal,txn_limbo: a few cleanups Vladislav Shpilevoy via Tarantool-patches
2021-04-26 15:40 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIVuIe9J4rbZzZSC@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox