From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH v2] txn_limbo: simplify owner migration condition Date: Fri, 16 Apr 2021 10:17:31 +0300 [thread overview] Message-ID: <YHk6C1K3CO1d2x5O@grain> (raw) In-Reply-To: <8f84416e-440e-8f31-e673-f182fd402c18@tarantool.org> When limbo owner is about to change the state we should check if there are some pending transactions which are not yet processed, iow if queue is empty. No need to test if current limbo owner is zero. The owner is set to zero once -- when limbo is created during initialization. After all I think even if owner would ever zero and we're about to change it the queue simply must be empty, that is the only safe state. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/txn_limbo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: tarantool.git/src/box/txn_limbo.c =================================================================== --- tarantool.git.orig/src/box/txn_limbo.c +++ tarantool.git/src/box/txn_limbo.c @@ -94,8 +94,7 @@ txn_limbo_append(struct txn_limbo *limbo id = instance_id; bool make_ro = false; if (limbo->owner_id != id) { - if (limbo->owner_id == REPLICA_ID_NIL || - rlist_empty(&limbo->queue)) { + if (rlist_empty(&limbo->queue)) { limbo->owner_id = id; limbo->confirmed_lsn = 0; if (id != instance_id)
next prev parent reply other threads:[~2021-04-16 7:17 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-15 22:06 [Tarantool-patches] [PATCH] " Cyrill Gorcunov via Tarantool-patches 2021-04-15 23:12 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-16 7:17 ` Cyrill Gorcunov via Tarantool-patches [this message] 2021-04-16 19:29 ` [Tarantool-patches] [PATCH v2] " Vladislav Shpilevoy via Tarantool-patches 2021-04-16 20:36 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YHk6C1K3CO1d2x5O@grain \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2] txn_limbo: simplify owner migration condition' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox