Re: [Tarantool-patches] [PATCH v2 1/9] wal: enrich row's meta information with sync replication flags

[Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On Tue, Apr 13, 2021 at 04:51:52PM +0300, Serge Petrenko wrote:
> 
> 
> 13.04.2021 14:50, Cyrill Gorcunov пишет:
> > On Mon, Apr 12, 2021 at 10:40:14PM +0300, Serge Petrenko wrote:
> > > Introduce two new flags to xrow_header: `wait_ack` and `wait_sync`.
> > > These flags are set for rows belonging to synchronous transactions in
> > > addition to `is_commit`.
> > > 
> > > The new flags help to define whether the rows belong to a synchronous
> > > transaction or not without parsing them all and checking whether any of
> > > the rows touches a synchronous space.
> > > 
> > > This will be used in applier once it is taught to filter synchronous
> > > transactions based on whether they are coming from a raft leader or not.
> > > 
> > > P.S. These flags will also be useful once we allow to turn any transaction
> > > synchronous. Once this is done, the flags in row header will be the only
> > > source of information on whether the transaction is synchronous or not.
> > > 
> > > Prerequisite #5445
> > Serge, here is a one addition: lets verify bitfields order. While their
> > use indeed is suitable we should eliminate ourself from unpredicted results.
> > The test is for c++ and probably we need one for plain c compiler as well?
> 
> Thanks for the help! I've added your tests with some changes.
> What do you think?
> 

Ack