From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v21 3/6] box/module_cache: introduce modules subsystem
Date: Sat, 10 Apr 2021 17:59:34 +0300 [thread overview]
Message-ID: <YHG9VleVVjKnLvYr@grain> (raw)
In-Reply-To: <b1c062ea-1781-8ecf-5ac9-23cc1be80db2@tarantool.org>
On Sat, Apr 10, 2021 at 01:54:43AM +0200, Vladislav Shpilevoy wrote:
> > +void
> > +module_free(void)
> > +{
> > + while (mh_size(module_cache) > 0) {
> > + mh_int_t e = mh_first(module_cache);
> > + mh_strnptr_del(module_cache, e, NULL);
>
> Is this loop really needed? It seems the mhash delete()
> frees all the memory anyway.
Thanks, Vlad! Ineed this is not needed. I force-pushed an update.
next prev parent reply other threads:[~2021-04-10 14:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:41 [Tarantool-patches] [PATCH v21 0/6] box: implement box.lib Lua module Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 1/6] box/func: fix modules functions restore Cyrill Gorcunov via Tarantool-patches
2021-04-09 23:31 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:02 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 2/6] box/func: module_reload -- drop redundant argument Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 3/6] box/module_cache: introduce modules subsystem Cyrill Gorcunov via Tarantool-patches
2021-04-09 23:54 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 14:59 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 4/6] box/schema.func: switch to new module api Cyrill Gorcunov via Tarantool-patches
2021-04-09 23:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:00 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 5/6] box: implement box.lib module Cyrill Gorcunov via Tarantool-patches
2021-04-11 15:38 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-11 22:38 ` Cyrill Gorcunov via Tarantool-patches
2021-04-12 22:08 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-12 22:34 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test Cyrill Gorcunov via Tarantool-patches
2021-04-08 18:53 ` Cyrill Gorcunov via Tarantool-patches
2021-04-11 15:43 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-11 21:56 ` Cyrill Gorcunov via Tarantool-patches
2021-04-11 22:36 ` Cyrill Gorcunov via Tarantool-patches
2021-04-12 22:08 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-13 7:10 ` Cyrill Gorcunov via Tarantool-patches
2021-04-13 21:53 ` [Tarantool-patches] [PATCH v21 0/6] box: implement box.lib Lua module Vladislav Shpilevoy via Tarantool-patches
2021-04-14 8:07 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHG9VleVVjKnLvYr@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v21 3/6] box/module_cache: introduce modules subsystem' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox