From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v20 1/7] box/schema: make sure hashes are created
Date: Tue, 6 Apr 2021 10:44:11 +0300 [thread overview]
Message-ID: <YGwRS+Mn0dohIPtE@grain> (raw)
In-Reply-To: <4fdbd792-71a6-a19e-bf91-03902b22054a@tarantool.org>
On Mon, Apr 05, 2021 at 05:45:54PM +0200, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> I don't think this patch is needed, because it would crash anyway later,
> if the hashes couldn't be allocated. On any of their usages. But
> whatever.
>
> I also don't see how it is 'in scope of 4642'. It is completely
> unrelated. So please, at least drop the reference.
I filed a new bug https://github.com/tarantool/tarantool/issues/5967
and will address it separately later then.
next prev parent reply other threads:[~2021-04-06 7:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 12:34 [Tarantool-patches] [PATCH v20 0/7] box: implement box.lib Lua module Cyrill Gorcunov via Tarantool-patches
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 1/7] box/schema: make sure hashes are created Cyrill Gorcunov via Tarantool-patches
2021-04-05 9:28 ` Serge Petrenko via Tarantool-patches
2021-04-05 9:50 ` Cyrill Gorcunov via Tarantool-patches
2021-04-05 10:13 ` Serge Petrenko via Tarantool-patches
2021-04-05 15:45 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-06 7:44 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 2/7] box/func: module_reload -- drop redundant argument Cyrill Gorcunov via Tarantool-patches
2021-04-05 10:23 ` Serge Petrenko via Tarantool-patches
2021-04-05 10:26 ` Serge Petrenko via Tarantool-patches
2021-04-05 10:31 ` Cyrill Gorcunov via Tarantool-patches
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 3/7] box/func: fix modules functions restore Cyrill Gorcunov via Tarantool-patches
2021-04-05 10:53 ` Serge Petrenko via Tarantool-patches
2021-04-05 11:26 ` Cyrill Gorcunov via Tarantool-patches
2021-04-05 11:42 ` Serge Petrenko via Tarantool-patches
2021-04-05 15:47 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-06 8:38 ` Cyrill Gorcunov via Tarantool-patches
2021-04-06 20:02 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-06 20:42 ` Cyrill Gorcunov via Tarantool-patches
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 4/7] box/module_cache: introduce modules subsystem Cyrill Gorcunov via Tarantool-patches
2021-04-05 12:34 ` Serge Petrenko via Tarantool-patches
2021-04-05 15:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-06 14:33 ` Cyrill Gorcunov via Tarantool-patches
2021-04-06 20:09 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-06 22:05 ` Cyrill Gorcunov via Tarantool-patches
2021-04-06 23:43 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-07 7:03 ` Cyrill Gorcunov via Tarantool-patches
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 5/7] box/schema.func: switch to new module api Cyrill Gorcunov via Tarantool-patches
2021-04-05 15:56 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 6/7] box: implement box.lib module Cyrill Gorcunov via Tarantool-patches
2021-04-05 16:04 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-07 16:59 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 20:22 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 20:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-07 20:37 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 20:45 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 21:04 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-02 12:34 ` [Tarantool-patches] [PATCH v20 7/7] test: add box.lib test Cyrill Gorcunov via Tarantool-patches
2021-04-05 16:04 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-05 15:45 ` [Tarantool-patches] [PATCH v20 0/7] box: implement box.lib Lua module Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGwRS+Mn0dohIPtE@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v20 1/7] box/schema: make sure hashes are created' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox