Re: [Tarantool-patches] [PATCH v2 luajit 04/30] test: remove quotes in progname from <main.lua>

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Igor,

Thanks for the review!

On 01.04.21, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except the nits below.
> 
> On 26.03.21, Sergey Kaplun wrote:
> > When LUAJIT_TEST_COMMAND extend the least `arg` with
> 
> Typo: s/LUAJIT_TEST_COMMAND extend/LUAJIT_TEST_COMMAND extends/.
> Typo: s/the least `arg`/the least `arg` slot/.

Fixed.

> 
> > some string containing double quotes, bash failed to exec this
> 
> Minor: I believe you're not talking about bash here, but rather
> about <os.execute> and hence system(3) command, IIRC.

Fixed. Thanks!

> 
> > command for child test.
> > 
> > This patch removes edged '"' to be able run extended command
> 
> Minor: I guess "framing" fits better than "edging".
> Typo: s/to be able run extended/to be able to run an extended/.

Fixed.

> 
> > containing '"' and run other test suites.
> > 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---
> >  test/PUC-Lua-5.1-tests/main.lua | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua
> > index f520896..4f8b8bf 100644
> > --- a/test/PUC-Lua-5.1-tests/main.lua
> > +++ b/test/PUC-Lua-5.1-tests/main.lua
> > @@ -11,7 +11,9 @@ out = os.tmpname()
> >  do
> >    local i = 0
> >    while arg[i] do i=i-1 end
> > -  progname = '"'..arg[i+1]..'"'
> > +  -- LuaJIT: remove edged '"' to be able run extended command
> 
> Minor: I guess "framing" fits better than "edging".
> Typo: s/to be able run extended/to be able to run an extended/.

Fixed.

> 
> > +  -- containing '"' and run other test suites.
> > +  progname = arg[i+1]
> >  end
> >  print(progname)
> >  
> 
> <snipped>
> 
> > -- 
> > 2.31.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun