From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option
Date: Tue, 30 Mar 2021 00:57:35 +0300 [thread overview]
Message-ID: <YGJNTxVMrnjZDgQh@grain> (raw)
In-Reply-To: <db0b6fbd-0755-3a85-381c-06096585e931@tarantool.org>
On Mon, Mar 29, 2021 at 11:54:45PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
>
> Please, don't try to rush and answer my comments immediately after
> I send them. Even if they seem trivial. It won't speed the things
> up, and you will simply miss something, as I told many times.
>
> You still left 3 usages of 'is_paused == false', even though
> I specifically said this is the most confusing one.
I need to make sure the .is_paused is false, the assert(x == false)
looks exactly what is needed. and we have similar code in our other
tests, do you prefer assert(not x.is_paused) or what?
next prev parent reply other threads:[~2021-03-29 21:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 11:13 [Tarantool-patches] [PATCH v6 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
2021-03-27 11:13 ` [Tarantool-patches] [PATCH v6 1/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-27 11:13 ` [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches
2021-03-29 21:07 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-29 21:46 ` Cyrill Gorcunov via Tarantool-patches
2021-03-29 21:54 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-29 21:57 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-03-29 22:19 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-29 22:40 ` Cyrill Gorcunov via Tarantool-patches
2021-03-29 22:56 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-30 7:19 ` Cyrill Gorcunov via Tarantool-patches
2021-03-30 11:55 ` Cyrill Gorcunov via Tarantool-patches
2021-03-30 19:59 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-27 11:13 ` [Tarantool-patches] [PATCH v6 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches
2021-03-30 19:57 ` [Tarantool-patches] [PATCH v6 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Vladislav Shpilevoy via Tarantool-patches
2021-03-31 8:28 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGJNTxVMrnjZDgQh@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox