From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test Date: Thu, 8 Apr 2021 21:53:24 +0300 [thread overview] Message-ID: <YG9RJDOFFr3jeo4+@grain> (raw) In-Reply-To: <20210408164151.1759348-7-gorcunov@gmail.com> Guys, I had to update the test. I managed to run tests on patched test-run repo so didn't notice the issue until read logs from github. I force pushed an update. Here is the whole patch --- test/box/CMakeLists.txt | 4 + test/box/cfunc1.c | 58 +++++ test/box/cfunc2.c | 137 +++++++++++ test/box/cfunc3.c | 25 ++ test/box/cfunc4.c | 28 +++ test/box/lib.result | 527 ++++++++++++++++++++++++++++++++++++++++ test/box/lib.test.lua | 202 +++++++++++++++ 7 files changed, 981 insertions(+) create mode 100644 test/box/cfunc1.c create mode 100644 test/box/cfunc2.c create mode 100644 test/box/cfunc3.c create mode 100644 test/box/cfunc4.c create mode 100644 test/box/lib.result create mode 100644 test/box/lib.test.lua diff --git a/test/box/CMakeLists.txt b/test/box/CMakeLists.txt index 4216a0ba9..51db15653 100644 --- a/test/box/CMakeLists.txt +++ b/test/box/CMakeLists.txt @@ -7,3 +7,7 @@ build_module(func_restore2 func_restore2.c) build_module(func_restore3 func_restore3.c) build_module(func_restore4 func_restore4.c) build_module(tuple_bench tuple_bench.c) +build_module(cfunc1 cfunc1.c) +build_module(cfunc2 cfunc2.c) +build_module(cfunc3 cfunc3.c) +build_module(cfunc4 cfunc4.c) diff --git a/test/box/cfunc1.c b/test/box/cfunc1.c new file mode 100644 index 000000000..f6829372a --- /dev/null +++ b/test/box/cfunc1.c @@ -0,0 +1,58 @@ +#include <stdio.h> +#include <stdbool.h> +#include <msgpuck.h> + +#include "module.h" + +/* + * Before the reload functions are just declared + * and simply exit with zero. + * + * After the module reload we should provide real + * functionality. + */ + +int +cfunc_nop(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + (void)ctx; + (void)args; + (void)args_end; + return 0; +} + +int +cfunc_fetch_seq_evens(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + (void)ctx; + (void)args; + (void)args_end; + return 0; +} + +int +cfunc_multireturn(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + (void)ctx; + (void)args; + (void)args_end; + return 0; +} + +int +cfunc_args(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + (void)ctx; + (void)args; + (void)args_end; + return 0; +} + +int +cfunc_sum(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + (void)ctx; + (void)args; + (void)args_end; + return 0; +} diff --git a/test/box/cfunc2.c b/test/box/cfunc2.c new file mode 100644 index 000000000..8c583e993 --- /dev/null +++ b/test/box/cfunc2.c @@ -0,0 +1,137 @@ +#include <stdio.h> +#include <stdbool.h> +#include <msgpuck.h> + +#include "module.h" + +/* + * Just make sure we've been called. + */ +int +cfunc_nop(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + (void)ctx; + (void)args; + (void)args_end; + return 0; +} + +/* + * Fetch first N even numbers (just to make sure the order of + * arguments is not screwed). + */ +int +cfunc_fetch_seq_evens(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + int arg_count = mp_decode_array(&args); + if (arg_count != 1) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "invalid argument count"); + } + int field_count = mp_decode_array(&args); + if (field_count < 1) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "invalid array size"); + } + + /* + * We expect even numbers sequence here. The idea is + * to test invalid data an issue an error from inside + * of C function. + */ + for (int i = 1; i <= field_count; i++) { + int val = mp_decode_uint(&args); + int needed = 2 * i; + if (val != needed) { + char res[128]; + snprintf(res, sizeof(res), "%s %d != %d", + "invalid argument", val, needed); + return box_error_set(__FILE__, __LINE__, + ER_PROC_C, "%s", res); + } + } + + return 0; +} + +/* + * Return one element array twice. + */ +int +cfunc_multireturn(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + char tuple_buf[512]; + char *d = tuple_buf; + d = mp_encode_array(d, 1); + d = mp_encode_uint(d, 1); + assert(d <= tuple_buf + sizeof(tuple_buf)); + + box_tuple_format_t *fmt = box_tuple_format_default(); + box_tuple_t *tuple_a = box_tuple_new(fmt, tuple_buf, d); + if (tuple_a == NULL) + return -1; + int rc = box_return_tuple(ctx, tuple_a); + if (rc == 0) + return box_return_tuple(ctx, tuple_a); + return rc; +} + +/* + * Encode int + string pair back. + */ +int +cfunc_args(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + uint32_t arg_count = mp_decode_array(&args); + if (arg_count != 2) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "invalid argument count"); + } + + if (mp_typeof(*args) != MP_UINT) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "tuple field must be uint"); + } + uint32_t num = mp_decode_uint(&args); + + if (mp_typeof(*args) != MP_STR) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "tuple field must be string"); + } + const char *str = args; + uint32_t len = mp_decode_strl(&str); + + char tuple_buf[512]; + char *d = tuple_buf; + d = mp_encode_array(d, 2); + d = mp_encode_uint(d, num); + d = mp_encode_str(d, str, len); + assert(d <= tuple_buf + sizeof(tuple_buf)); + + box_tuple_format_t *fmt = box_tuple_format_default(); + box_tuple_t *tuple = box_tuple_new(fmt, tuple_buf, d); + if (tuple == NULL) + return -1; + + return box_return_tuple(ctx, tuple); +} + +/* + * Sum two integers. + */ +int +cfunc_sum(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + uint32_t arg_count = mp_decode_array(&args); + if (arg_count != 2) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "invalid argument count"); + } + uint64_t a = mp_decode_uint(&args); + uint64_t b = mp_decode_uint(&args); + + char res[16]; + char *end = mp_encode_uint(res, a + b); + box_return_mp(ctx, res, end); + return 0; +} diff --git a/test/box/cfunc3.c b/test/box/cfunc3.c new file mode 100644 index 000000000..668790fbf --- /dev/null +++ b/test/box/cfunc3.c @@ -0,0 +1,25 @@ +#include <stdio.h> +#include <stdbool.h> +#include <msgpuck.h> + +#include "module.h" + +/* + * Sum two integers. + */ +int +cfunc_add(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + uint32_t arg_count = mp_decode_array(&args); + if (arg_count != 2) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "invalid argument count"); + } + uint64_t a = mp_decode_uint(&args); + uint64_t b = mp_decode_uint(&args); + + char res[16]; + char *end = mp_encode_uint(res, a + b); + box_return_mp(ctx, res, end); + return 0; +} diff --git a/test/box/cfunc4.c b/test/box/cfunc4.c new file mode 100644 index 000000000..cc079b335 --- /dev/null +++ b/test/box/cfunc4.c @@ -0,0 +1,28 @@ +#include <stdio.h> +#include <stdbool.h> +#include <msgpuck.h> + +#include "module.h" + +/* + * Sum two integers and add a constant, + * so that result will be different after + * the reload. + */ +int +cfunc_add(box_function_ctx_t *ctx, const char *args, const char *args_end) +{ + const uint32_t delta = 10; + uint32_t arg_count = mp_decode_array(&args); + if (arg_count != 2) { + return box_error_set(__FILE__, __LINE__, ER_PROC_C, "%s", + "invalid argument count"); + } + uint64_t a = mp_decode_uint(&args); + uint64_t b = mp_decode_uint(&args); + + char res[16]; + char *end = mp_encode_uint(res, a + b + delta); + box_return_mp(ctx, res, end); + return 0; +} diff --git a/test/box/lib.result b/test/box/lib.result new file mode 100644 index 000000000..2986df049 --- /dev/null +++ b/test/box/lib.result @@ -0,0 +1,527 @@ +-- test-run result file version 2 +-- +-- gh-4642: New box.lib module to be able to +-- run C stored functions on read only nodes +-- without requirement to register them with +-- box.schema.func help. +-- +build_path = os.getenv("BUILDDIR") + | --- + | ... +package.cpath = build_path..'/test/box/?.so;'..build_path..'/test/box/?.dylib;'..package.cpath + | --- + | ... + +fio = require('fio') + | --- + | ... + +ext = (jit.os == "OSX" and "dylib" or "so") + | --- + | ... + +cfunc_path = fio.pathjoin(build_path, "test/box/cfunc.") .. ext + | --- + | ... +cfunc1_path = fio.pathjoin(build_path, "test/box/cfunc1.") .. ext + | --- + | ... +cfunc2_path = fio.pathjoin(build_path, "test/box/cfunc2.") .. ext + | --- + | ... +cfunc3_path = fio.pathjoin(build_path, "test/box/cfunc3.") .. ext + | --- + | ... +cfunc4_path = fio.pathjoin(build_path, "test/box/cfunc4.") .. ext + | --- + | ... + +_ = pcall(fio.unlink(cfunc_path)) + | --- + | ... +fio.symlink(cfunc1_path, cfunc_path) + | --- + | - true + | ... + +_, err = pcall(box.lib.load, 'non-such-module') + | --- + | ... +assert(err ~= nil) + | --- + | - true + | ... + +-- All functions are sitting in cfunc.so. +old_module = box.lib.load('cfunc') + | --- + | ... +assert(old_module['debug_refs'] == 1) + | --- + | - true + | ... +old_module_copy = box.lib.load('cfunc') + | --- + | ... +assert(old_module['debug_refs'] == 2) + | --- + | - true + | ... +assert(old_module_copy['debug_refs'] == 2) + | --- + | - true + | ... +old_module_copy:unload() + | --- + | - true + | ... +assert(old_module['debug_refs'] == 1) + | --- + | - true + | ... +old_cfunc_nop = old_module:load('cfunc_nop') + | --- + | ... +old_cfunc_fetch_seq_evens = old_module:load('cfunc_fetch_seq_evens') + | --- + | ... +old_cfunc_multireturn = old_module:load('cfunc_multireturn') + | --- + | ... +old_cfunc_args = old_module:load('cfunc_args') + | --- + | ... +old_cfunc_sum = old_module:load('cfunc_sum') + | --- + | ... +assert(old_module['debug_refs'] == 6) + | --- + | - true + | ... + +-- Test for error on nonexisting function. +_, err = pcall(old_module.load, old_module, 'no-such-func') + | --- + | ... +assert(err ~= nil) + | --- + | - true + | ... + +-- Make sure they all are callable. +old_cfunc_nop() + | --- + | ... +old_cfunc_fetch_seq_evens() + | --- + | ... +old_cfunc_multireturn() + | --- + | ... +old_cfunc_args() + | --- + | ... +old_cfunc_sum() + | --- + | ... + +-- Unload the module but keep old functions alive, so +-- they keep reference to NOP module internally +-- and still callable. +old_module:unload() + | --- + | - true + | ... +-- Test refs via function name. +assert(old_cfunc_nop['debug_module_refs'] == 5) + | --- + | - true + | ... +old_cfunc_nop() + | --- + | ... +old_cfunc_fetch_seq_evens() + | --- + | ... +old_cfunc_multireturn() + | --- + | ... +old_cfunc_args() + | --- + | ... +old_cfunc_sum() + | --- + | ... + +-- The module is unloaded I should not be able +-- to load new shared library. +old_module:load('cfunc') + | --- + | - error: Expects function = module:load('name') but not module object passed + | ... +-- Neither I should be able to unload module twise. +old_module:unload() + | --- + | - error: The module is unloaded + | ... + +-- Clean old functions. +old_cfunc_nop:unload() + | --- + | - true + | ... +old_cfunc_fetch_seq_evens:unload() + | --- + | - true + | ... +old_cfunc_multireturn:unload() + | --- + | - true + | ... +old_cfunc_args:unload() + | --- + | - true + | ... +assert(old_cfunc_sum['debug_module_refs'] == 1) + | --- + | - true + | ... +old_cfunc_sum:unload() + | --- + | - true + | ... + +-- And reload old module again. +old_module = box.lib.load('cfunc') + | --- + | ... +old_module_ptr = old_module['debug_ptr'] + | --- + | ... +assert(old_module['debug_refs'] == 1) + | --- + | - true + | ... + +-- Overwrite module with new contents. +_ = pcall(fio.unlink(cfunc_path)) + | --- + | ... +fio.symlink(cfunc2_path, cfunc_path) + | --- + | - true + | ... + +-- Load new module, cache should be updated. +new_module = box.lib.load('cfunc') + | --- + | ... +new_module_ptr = new_module['debug_ptr'] + | --- + | ... + +-- Old and new module keep one reference with +-- different IDs. +assert(old_module['debug_refs'] == 1) + | --- + | - true + | ... +assert(old_module['debug_refs'] == new_module['debug_refs']) + | --- + | - true + | ... +assert(old_module_ptr ~= new_module_ptr) + | --- + | - true + | ... + +-- All functions from old module should be loadable. +old_cfunc_nop = old_module:load('cfunc_nop') + | --- + | ... +old_cfunc_fetch_seq_evens = old_module:load('cfunc_fetch_seq_evens') + | --- + | ... +old_cfunc_multireturn = old_module:load('cfunc_multireturn') + | --- + | ... +old_cfunc_args = old_module:load('cfunc_args') + | --- + | ... +old_cfunc_sum = old_module:load('cfunc_sum') + | --- + | ... +assert(old_cfunc_nop['debug_module_ptr'] == old_module_ptr) + | --- + | - true + | ... +assert(old_cfunc_fetch_seq_evens['debug_module_ptr'] == old_module_ptr) + | --- + | - true + | ... +assert(old_cfunc_multireturn['debug_module_ptr'] == old_module_ptr) + | --- + | - true + | ... +assert(old_cfunc_args['debug_module_ptr'] == old_module_ptr) + | --- + | - true + | ... +assert(old_cfunc_sum['debug_module_ptr'] == old_module_ptr) + | --- + | - true + | ... +assert(old_module['debug_refs'] == 6) + | --- + | - true + | ... + +-- Lookup for updated symbols. +new_cfunc_nop = new_module:load('cfunc_nop') + | --- + | ... +new_cfunc_fetch_seq_evens = new_module:load('cfunc_fetch_seq_evens') + | --- + | ... +new_cfunc_multireturn = new_module:load('cfunc_multireturn') + | --- + | ... +new_cfunc_args = new_module:load('cfunc_args') + | --- + | ... +new_cfunc_sum = new_module:load('cfunc_sum') + | --- + | ... +assert(new_cfunc_nop['debug_module_ptr'] == new_module_ptr) + | --- + | - true + | ... +assert(new_cfunc_fetch_seq_evens['debug_module_ptr'] == new_module_ptr) + | --- + | - true + | ... +assert(new_cfunc_multireturn['debug_module_ptr'] == new_module_ptr) + | --- + | - true + | ... +assert(new_cfunc_args['debug_module_ptr'] == new_module_ptr) + | --- + | - true + | ... +assert(new_cfunc_sum['debug_module_ptr'] == new_module_ptr) + | --- + | - true + | ... +assert(new_module['debug_refs'] == 6) + | --- + | - true + | ... + +-- Call old functions. +old_cfunc_nop() + | --- + | ... +old_cfunc_fetch_seq_evens() + | --- + | ... +old_cfunc_multireturn() + | --- + | ... +old_cfunc_args() + | --- + | ... +old_cfunc_sum() + | --- + | ... + +-- Call new functions. +new_cfunc_nop() + | --- + | ... +new_cfunc_multireturn() + | --- + | - [1] + | - [1] + | ... +new_cfunc_fetch_seq_evens({2,4,6}) + | --- + | ... +new_cfunc_fetch_seq_evens({1,2,3}) -- error, odd numbers sequence + | --- + | - error: invalid argument 1 != 2 + | ... +new_cfunc_args(1, "hello") + | --- + | - [1, 'hello'] + | ... +new_cfunc_sum(1) -- error, one arg passed + | --- + | - error: invalid argument count + | ... +new_cfunc_sum(1,2) + | --- + | - 3 + | ... + +-- Cleanup old module's functions. +old_cfunc_nop:unload() + | --- + | - true + | ... +old_cfunc_fetch_seq_evens:unload() + | --- + | - true + | ... +old_cfunc_multireturn:unload() + | --- + | - true + | ... +old_cfunc_args:unload() + | --- + | - true + | ... +old_cfunc_sum:unload() + | --- + | - true + | ... +old_module:unload() + | --- + | - true + | ... + +-- Cleanup new module data. +new_cfunc_nop:unload() + | --- + | - true + | ... +new_cfunc_multireturn:unload() + | --- + | - true + | ... +new_cfunc_fetch_seq_evens:unload() + | --- + | - true + | ... +new_cfunc_args:unload() + | --- + | - true + | ... +new_cfunc_sum:unload() + | --- + | - true + | ... +new_module:unload() + | --- + | - true + | ... + +-- Cleanup the generated symlink. +_ = pcall(fio.unlink(cfunc_path)) + | --- + | ... + +-- Test double hashing: create function +-- in box.schema.fun so that it should +-- appear in box.lib hash. +fio.symlink(cfunc3_path, cfunc_path) + | --- + | - true + | ... +box.schema.func.create('cfunc.cfunc_add', {language = "C"}) + | --- + | ... +box.schema.user.grant('guest', 'execute', 'function', 'cfunc.cfunc_add') + | --- + | ... +box.func['cfunc.cfunc_add']:call({1,2}) + | --- + | - 3 + | ... + +old_module = box.lib.load('cfunc') + | --- + | ... +assert(old_module['debug_refs'] == 3) -- box.lib + 2 box.schema.func + | --- + | - true + | ... +old_func = old_module:load('cfunc_add') + | --- + | ... +assert(old_module['debug_refs'] == 4) -- plus function instance + | --- + | - true + | ... +old_func(1,2) + | --- + | - 3 + | ... + +-- Now update on disk and reload the module. +_ = pcall(fio.unlink(cfunc_path)) + | --- + | ... +fio.symlink(cfunc4_path, cfunc_path) + | --- + | - true + | ... + +box.schema.func.reload("cfunc") + | --- + | ... +box.func['cfunc.cfunc_add']:call({1,2}) + | --- + | - 13 + | ... + +-- The box.lib instance should carry own +-- references to the module and old +-- function. And reloading must not +-- affect old functions. Thus one for +-- box.lib and one for box.lib function. +assert(old_module['debug_refs'] == 2) + | --- + | - true + | ... +old_func(1,2) + | --- + | - 3 + | ... +old_func:unload() + | --- + | - true + | ... +old_module:unload() + | --- + | - true + | ... + +-- Same time the reload should update +-- low level module cache, thus two +-- for box and box function plus one +-- new box.lib. +new_module = box.lib.load('cfunc') + | --- + | ... +assert(new_module['debug_refs'] == 3) + | --- + | - true + | ... + +-- Box function should carry own module. +box.func['cfunc.cfunc_add']:call({1,2}) + | --- + | - 13 + | ... + +-- Cleanup. +_ = pcall(fio.unlink(cfunc_path)) + | --- + | ... +new_module:unload() + | --- + | - true + | ... +box.schema.func.drop('cfunc.cfunc_add') + | --- + | ... diff --git a/test/box/lib.test.lua b/test/box/lib.test.lua new file mode 100644 index 000000000..387c813c4 --- /dev/null +++ b/test/box/lib.test.lua @@ -0,0 +1,202 @@ +-- +-- gh-4642: New box.lib module to be able to +-- run C stored functions on read only nodes +-- without requirement to register them with +-- box.schema.func help. +-- +build_path = os.getenv("BUILDDIR") +package.cpath = build_path..'/test/box/?.so;'..build_path..'/test/box/?.dylib;'..package.cpath + +fio = require('fio') + +ext = (jit.os == "OSX" and "dylib" or "so") + +cfunc_path = fio.pathjoin(build_path, "test/box/cfunc.") .. ext +cfunc1_path = fio.pathjoin(build_path, "test/box/cfunc1.") .. ext +cfunc2_path = fio.pathjoin(build_path, "test/box/cfunc2.") .. ext +cfunc3_path = fio.pathjoin(build_path, "test/box/cfunc3.") .. ext +cfunc4_path = fio.pathjoin(build_path, "test/box/cfunc4.") .. ext + +_ = pcall(fio.unlink(cfunc_path)) +fio.symlink(cfunc1_path, cfunc_path) + +_, err = pcall(box.lib.load, 'non-such-module') +assert(err ~= nil) + +-- All functions are sitting in cfunc.so. +old_module = box.lib.load('cfunc') +assert(old_module['debug_refs'] == 1) +old_module_copy = box.lib.load('cfunc') +assert(old_module['debug_refs'] == 2) +assert(old_module_copy['debug_refs'] == 2) +old_module_copy:unload() +assert(old_module['debug_refs'] == 1) +old_cfunc_nop = old_module:load('cfunc_nop') +old_cfunc_fetch_seq_evens = old_module:load('cfunc_fetch_seq_evens') +old_cfunc_multireturn = old_module:load('cfunc_multireturn') +old_cfunc_args = old_module:load('cfunc_args') +old_cfunc_sum = old_module:load('cfunc_sum') +assert(old_module['debug_refs'] == 6) + +-- Test for error on nonexisting function. +_, err = pcall(old_module.load, old_module, 'no-such-func') +assert(err ~= nil) + +-- Make sure they all are callable. +old_cfunc_nop() +old_cfunc_fetch_seq_evens() +old_cfunc_multireturn() +old_cfunc_args() +old_cfunc_sum() + +-- Unload the module but keep old functions alive, so +-- they keep reference to NOP module internally +-- and still callable. +old_module:unload() +-- Test refs via function name. +assert(old_cfunc_nop['debug_module_refs'] == 5) +old_cfunc_nop() +old_cfunc_fetch_seq_evens() +old_cfunc_multireturn() +old_cfunc_args() +old_cfunc_sum() + +-- The module is unloaded I should not be able +-- to load new shared library. +old_module:load('cfunc') +-- Neither I should be able to unload module twise. +old_module:unload() + +-- Clean old functions. +old_cfunc_nop:unload() +old_cfunc_fetch_seq_evens:unload() +old_cfunc_multireturn:unload() +old_cfunc_args:unload() +assert(old_cfunc_sum['debug_module_refs'] == 1) +old_cfunc_sum:unload() + +-- And reload old module again. +old_module = box.lib.load('cfunc') +old_module_ptr = old_module['debug_ptr'] +assert(old_module['debug_refs'] == 1) + +-- Overwrite module with new contents. +_ = pcall(fio.unlink(cfunc_path)) +fio.symlink(cfunc2_path, cfunc_path) + +-- Load new module, cache should be updated. +new_module = box.lib.load('cfunc') +new_module_ptr = new_module['debug_ptr'] + +-- Old and new module keep one reference with +-- different IDs. +assert(old_module['debug_refs'] == 1) +assert(old_module['debug_refs'] == new_module['debug_refs']) +assert(old_module_ptr ~= new_module_ptr) + +-- All functions from old module should be loadable. +old_cfunc_nop = old_module:load('cfunc_nop') +old_cfunc_fetch_seq_evens = old_module:load('cfunc_fetch_seq_evens') +old_cfunc_multireturn = old_module:load('cfunc_multireturn') +old_cfunc_args = old_module:load('cfunc_args') +old_cfunc_sum = old_module:load('cfunc_sum') +assert(old_cfunc_nop['debug_module_ptr'] == old_module_ptr) +assert(old_cfunc_fetch_seq_evens['debug_module_ptr'] == old_module_ptr) +assert(old_cfunc_multireturn['debug_module_ptr'] == old_module_ptr) +assert(old_cfunc_args['debug_module_ptr'] == old_module_ptr) +assert(old_cfunc_sum['debug_module_ptr'] == old_module_ptr) +assert(old_module['debug_refs'] == 6) + +-- Lookup for updated symbols. +new_cfunc_nop = new_module:load('cfunc_nop') +new_cfunc_fetch_seq_evens = new_module:load('cfunc_fetch_seq_evens') +new_cfunc_multireturn = new_module:load('cfunc_multireturn') +new_cfunc_args = new_module:load('cfunc_args') +new_cfunc_sum = new_module:load('cfunc_sum') +assert(new_cfunc_nop['debug_module_ptr'] == new_module_ptr) +assert(new_cfunc_fetch_seq_evens['debug_module_ptr'] == new_module_ptr) +assert(new_cfunc_multireturn['debug_module_ptr'] == new_module_ptr) +assert(new_cfunc_args['debug_module_ptr'] == new_module_ptr) +assert(new_cfunc_sum['debug_module_ptr'] == new_module_ptr) +assert(new_module['debug_refs'] == 6) + +-- Call old functions. +old_cfunc_nop() +old_cfunc_fetch_seq_evens() +old_cfunc_multireturn() +old_cfunc_args() +old_cfunc_sum() + +-- Call new functions. +new_cfunc_nop() +new_cfunc_multireturn() +new_cfunc_fetch_seq_evens({2,4,6}) +new_cfunc_fetch_seq_evens({1,2,3}) -- error, odd numbers sequence +new_cfunc_args(1, "hello") +new_cfunc_sum(1) -- error, one arg passed +new_cfunc_sum(1,2) + +-- Cleanup old module's functions. +old_cfunc_nop:unload() +old_cfunc_fetch_seq_evens:unload() +old_cfunc_multireturn:unload() +old_cfunc_args:unload() +old_cfunc_sum:unload() +old_module:unload() + +-- Cleanup new module data. +new_cfunc_nop:unload() +new_cfunc_multireturn:unload() +new_cfunc_fetch_seq_evens:unload() +new_cfunc_args:unload() +new_cfunc_sum:unload() +new_module:unload() + +-- Cleanup the generated symlink. +_ = pcall(fio.unlink(cfunc_path)) + +-- Test double hashing: create function +-- in box.schema.fun so that it should +-- appear in box.lib hash. +fio.symlink(cfunc3_path, cfunc_path) +box.schema.func.create('cfunc.cfunc_add', {language = "C"}) +box.schema.user.grant('guest', 'execute', 'function', 'cfunc.cfunc_add') +box.func['cfunc.cfunc_add']:call({1,2}) + +old_module = box.lib.load('cfunc') +assert(old_module['debug_refs'] == 3) -- box.lib + 2 box.schema.func +old_func = old_module:load('cfunc_add') +assert(old_module['debug_refs'] == 4) -- plus function instance +old_func(1,2) + +-- Now update on disk and reload the module. +_ = pcall(fio.unlink(cfunc_path)) +fio.symlink(cfunc4_path, cfunc_path) + +box.schema.func.reload("cfunc") +box.func['cfunc.cfunc_add']:call({1,2}) + +-- The box.lib instance should carry own +-- references to the module and old +-- function. And reloading must not +-- affect old functions. Thus one for +-- box.lib and one for box.lib function. +assert(old_module['debug_refs'] == 2) +old_func(1,2) +old_func:unload() +old_module:unload() + +-- Same time the reload should update +-- low level module cache, thus two +-- for box and box function plus one +-- new box.lib. +new_module = box.lib.load('cfunc') +assert(new_module['debug_refs'] == 3) + +-- Box function should carry own module. +box.func['cfunc.cfunc_add']:call({1,2}) + +-- Cleanup. +_ = pcall(fio.unlink(cfunc_path)) +new_module:unload() +box.schema.func.drop('cfunc.cfunc_add') -- 2.30.2
next prev parent reply other threads:[~2021-04-08 18:53 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-08 16:41 [Tarantool-patches] [PATCH v21 0/6] box: implement box.lib Lua module Cyrill Gorcunov via Tarantool-patches 2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 1/6] box/func: fix modules functions restore Cyrill Gorcunov via Tarantool-patches 2021-04-09 23:31 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 15:02 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 2/6] box/func: module_reload -- drop redundant argument Cyrill Gorcunov via Tarantool-patches 2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 3/6] box/module_cache: introduce modules subsystem Cyrill Gorcunov via Tarantool-patches 2021-04-09 23:54 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 14:59 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 4/6] box/schema.func: switch to new module api Cyrill Gorcunov via Tarantool-patches 2021-04-09 23:55 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 15:00 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 5/6] box: implement box.lib module Cyrill Gorcunov via Tarantool-patches 2021-04-11 15:38 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-11 22:38 ` Cyrill Gorcunov via Tarantool-patches 2021-04-12 22:08 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-12 22:34 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 16:41 ` [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test Cyrill Gorcunov via Tarantool-patches 2021-04-08 18:53 ` Cyrill Gorcunov via Tarantool-patches [this message] 2021-04-11 15:43 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-11 21:56 ` Cyrill Gorcunov via Tarantool-patches 2021-04-11 22:36 ` Cyrill Gorcunov via Tarantool-patches 2021-04-12 22:08 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-13 7:10 ` Cyrill Gorcunov via Tarantool-patches 2021-04-13 21:53 ` [Tarantool-patches] [PATCH v21 0/6] box: implement box.lib Lua module Vladislav Shpilevoy via Tarantool-patches 2021-04-14 8:07 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YG9RJDOFFr3jeo4+@grain \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v21 6/6] test: add box.lib test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox