From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] qsync: provide box.info interface for monitoring
Date: Thu, 8 Apr 2021 10:40:03 +0300 [thread overview]
Message-ID: <YG6zUyN9Kb5AQCHI@grain> (raw)
In-Reply-To: <0661429d-3059-00ff-d2ea-89a06c99f117@tarantool.org>
On Thu, Apr 08, 2021 at 10:34:56AM +0300, Serge Petrenko wrote:
> > +static int
> > +lbox_info_synchro(struct lua_State *L)
> > +{
> > + lua_newtable(L);
>
> Maybe change to lua_createtable(L, 0, 2) ?
> This will be consistent with what is done below, and lua doc
> states that'll be a bit faster:
> https://www.lua.org/manual/5.3/manual.html#lua_newtable
> (sorry, a direct link to lua_createtable didn't work)
Sure! Thanks!
next prev parent reply other threads:[~2021-04-08 7:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 15:58 [Tarantool-patches] [PATCH v2] " Cyrill Gorcunov via Tarantool-patches
2021-04-05 20:34 ` [Tarantool-patches] [PATCH v3] " Cyrill Gorcunov via Tarantool-patches
2021-04-08 7:34 ` Serge Petrenko via Tarantool-patches
2021-04-08 7:40 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-04-07 20:53 ` [Tarantool-patches] [PATCH v2] " Vladislav Shpilevoy via Tarantool-patches
2021-04-07 21:15 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 7:11 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 19:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 19:54 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 19:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 20:04 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 20:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 20:19 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG6zUyN9Kb5AQCHI@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] qsync: provide box.info interface for monitoring' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox