Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed

[Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On Fri, Mar 26, 2021 at 08:45:29PM +0100, Vladislav Shpilevoy wrote:
> > +++ b/test/replication/replica_rejoin.lua
> > @@ -0,0 +1,22 @@
> > +#!/usr/bin/env tarantool
> > +
> > +local repl_include_self = arg[1] and arg[1] == 'true' or false
> 
> 1. Why do you need that parameter? It is never used in the patch.

It is used on replica

> 
> > +local repl_list
> > +
> > +if repl_include_self then
> > +    repl_list = {os.getenv("MASTER"), os.getenv("LISTEN")}
> > +else
> > +    repl_list = os.getenv("MASTER")
> > +end
> > +
> > +-- Start the console first to allow test-run to attach even before
> > +-- box.cfg is finished.
> > +require('console').listen(os.getenv('ADMIN'))
> > +
> > +box.cfg({
> > +    listen              = os.getenv("LISTEN"),
> > +    replication         = repl_list,

^^^ here

And we run replica with

test_run:cmd("restart server replica with args='true'")
...

Since I use a separate replica_join.lua we could drop this
`if repl_include_self` sentense since we never call replica
with args='false'. I'll re-check.