From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed
Date: Fri, 26 Mar 2021 23:57:46 +0300 [thread overview]
Message-ID: <YF5Kyg1dijSzA1Ys@grain> (raw)
In-Reply-To: <f7eed387-757e-7551-a414-e612cde3c2ec@tarantool.org>
On Fri, Mar 26, 2021 at 08:45:29PM +0100, Vladislav Shpilevoy wrote:
> Hi! Danke schön für der Patch!
>
> See 3 comments below.
>
>
> > + replication_timeout = 0.1,
> > + wal_cleanup_delay = 0,
>
> 3. I would better propose you to patch replica.lua so as we could
> pass wal_cleanup_delay parameter to it somehow. But I don't mind
> if you would keep your way + remove the dead code above.
>
ありがとう！
Gimme some time, I'll try to patch replica.lua, if I won't manage
I'll drop these redundant lines.
Cyrill
next prev parent reply other threads:[~2021-03-26 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 12:06 [Tarantool-patches] [PATCH v5 0/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-26 12:06 ` [Tarantool-patches] [PATCH v5 1/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-26 13:42 ` Serge Petrenko via Tarantool-patches
2021-03-26 19:45 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-26 20:57 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-03-26 21:59 ` Cyrill Gorcunov via Tarantool-patches
2021-03-26 12:06 ` [Tarantool-patches] [PATCH v5 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches
2021-03-26 13:37 ` Serge Petrenko via Tarantool-patches
2021-03-26 13:57 ` Cyrill Gorcunov via Tarantool-patches
2021-03-26 19:45 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-26 12:06 ` [Tarantool-patches] [PATCH v5 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches
2021-03-26 12:08 ` [Tarantool-patches] [PATCH v5 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF5Kyg1dijSzA1Ys@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox