Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Igor!
Thanks for the patch!
Nice to see matrix in integrational workflow!
LGTM, with a single nit below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi!
> Thanks for the patch!
> LGTM, except for a few nits below.
> > 
> >>Considering the changes made in scope of the previous commit, it has

Typo: s/scope/the scope/

> >>been decided to dispatch LuaJIT integration testing to the runner the
> >>similar way (i.e. by using the pair of <matrix.ARCH> + <matrix.OS>
> >>values). As a result a new job with quite similar strategy matrix[1] is
> >>added as a successor for <test-luajit> job. The new job uses the new
> >>version (with <inputs.arch> and <inputs.os> parameters introduced and
> >>optional <inputs.host> obsolete parameter) of LuaJIT integration
> >Typo: s/optional/the optional/
> >Typo: s/of LuaJIT/of the LuaJIT/
> >>workflow from tarantool/tarantool repo.
> >Typo: s/from/from the/
> >>
> >>[1]:  https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow
> >>
> >>Signed-off-by: Igor Munkin < imun@tarantool.org >
> >>---
> >> .github/workflows/testing.yml | 190 ++++++----------------------------
> >> 1 file changed, 30 insertions(+), 160 deletions(-)
> >>
> >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> >>index 5558e3ea..d707ce83 100644
> >>--- a/.github/workflows/testing.yml
> >>+++ b/.github/workflows/testing.yml

<snipped>

> >>2.34.0
> >--
> >Best regards,
> >Maxim Kokryashkin

-- 
Best regards,
Sergey Kaplun