[Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI

Tarantool development patches archive
 help / color / mirror / Atom feed

* [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI
@ 2023-01-12 14:51 Igor Munkin via Tarantool-patches
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-12 14:51 UTC (permalink / raw)
  To: Sergey Kaplun, Maxim Kokryashkin; +Cc: tarantool-patches

This series consists of the two patches caused by recent runner renaming
activity.

The first one changes the way workflow is dispatched to the proper
runner (see the details in the corresponding commit message).

The second one caused by fluke: due to runner renaming we can't proceed
to use the previous approach to pass the machine name to LuaJIT
integration workflow. Hence, we ought to implement something similar
made in scope of the first patch. Occasionally, I've found that GitHub
team finally implemented strategy matrix for reusable workflows, so I
simply made a carbon copy of the <test-luajit> job configuration for
Tarantool integration testing. As a result the integration workflow is
also adjusted for the new runner dispatching strategy in scope of
#8145[1].

Branch: https://github.com/tarantool/luajit/tree/imun/fix-runner-names
CI is green: https://github.com/tarantool/luajit/commit/43adedc

[1]: https://github.com/tarantool/tarantool/pull/8145

Igor Munkin (2):
  ci: change runner dispatch for LuaJIT testing
  ci: use strategy matrix for integration workflow

 .github/workflows/gnumake-builds-testing.yml |  20 +-
 .github/workflows/lint.yml                   |   2 +-
 .github/workflows/testing.yml                | 210 +++----------------
 3 files changed, 35 insertions(+), 197 deletions(-)

-- 
2.34.0

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
  2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
@ 2023-01-12 14:51 ` Igor Munkin via Tarantool-patches
  2023-01-12 23:23   ` Maxim Kokryashkin via Tarantool-patches
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches
  2023-01-18  9:24 ` [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
  2 siblings, 1 reply; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-12 14:51 UTC (permalink / raw)
  To: Sergey Kaplun, Maxim Kokryashkin; +Cc: tarantool-patches

Before the patch the all LuaJIT testing jobs were dispatched to the
runner with the name given via strategy matrix <RUNNER> entry. However,
more convenient way for dispatching is the triplet of the following
labels:
* <matrix.ARCH> to specify the host architecture (i.e. x86_64 or ARM64)
* <matrix.OS> to specify the OS family name (either Linux or macOS)
* 'self-hosted' to make job dispatch only to the runners from Tarantool
  ghacts-shared-* pool and never choose GitHub public resources.

With the given triplet the proper runner is chosen for the particular
testing flavor.

Moreover, the new 'lightweight' and 'regular' labels are also used in
<runs-on> list, since the new "lightweight" runners have been introduced
to ghacts-shared-* pool. There are a couple of LuaJIT tests that
requires more memory than provided by "lightweight" runners, so only
"regular" ones need to be chosen for full LuaJIT testing. At the same
time there is no need to use "regular" runner for LuaJIT Static analysis
workflow, hence 'lightweight' label is added to <runs-on> list in
lint.yml workflow file.

Signed-off-by: Igor Munkin <imun@tarantool.org>
---
 .github/workflows/gnumake-builds-testing.yml | 20 ++------------------
 .github/workflows/lint.yml                   |  2 +-
 .github/workflows/testing.yml                | 20 ++------------------
 3 files changed, 5 insertions(+), 37 deletions(-)

diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
index ad9d5015..e5f82780 100644
--- a/.github/workflows/gnumake-builds-testing.yml
+++ b/.github/workflows/gnumake-builds-testing.yml
@@ -38,22 +38,6 @@ jobs:
         GC64: [ON, OFF]
         OS: [Linux, macOS]
         include:
-          - ARCH: ARM64
-            OS: Linux
-            NAME: Linux/aarch64
-            RUNNER: graviton
-          - ARCH: x86_64
-            OS: Linux
-            NAME: Linux/x86_64
-            RUNNER: ubuntu-20.04-self-hosted
-          - ARCH: ARM64
-            OS: macOS
-            NAME: macOS/M1
-            RUNNER: macos-11-m1
-          - ARCH: x86_64
-            OS: macOS
-            NAME: macOS/x86_64
-            RUNNER: macos-11
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
             MAKEBUILDFLAGS: -DLUA_USE_ASSERT -DLUA_USE_APICHECK
@@ -70,10 +54,10 @@ jobs:
             GC64: OFF
           - OS: macOS
             GC64: OFF
-    runs-on: [self-hosted, '${{ matrix.RUNNER }}']
+    runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
     name: >
       LuaJIT
-      (${{ matrix.NAME }})
+      (${{ matrix.OS }}/${{ matrix.ARCH }})
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index e565144c..02150922 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -30,7 +30,7 @@ concurrency:
 
 jobs:
   test-luacheck:
-    runs-on: ubuntu-20.04-self-hosted
+    runs-on: [self-hosted, lightweight, Linux, x86_64]
     name: luacheck
     steps:
       - uses: actions/checkout@v2.3.4
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index 958f8e27..5558e3ea 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -38,22 +38,6 @@ jobs:
         GC64: [ON, OFF]
         OS: [Linux, macOS]
         include:
-          - ARCH: ARM64
-            OS: Linux
-            NAME: Linux/aarch64
-            RUNNER: graviton
-          - ARCH: x86_64
-            OS: Linux
-            NAME: Linux/x86_64
-            RUNNER: ubuntu-20.04-self-hosted
-          - ARCH: ARM64
-            OS: macOS
-            NAME: macOS/M1
-            RUNNER: macos-11-m1
-          - ARCH: x86_64
-            OS: macOS
-            NAME: macOS/x86_64
-            RUNNER: macos-11
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
           - BUILDTYPE: Release
@@ -63,10 +47,10 @@ jobs:
             GC64: OFF
           - OS: macOS
             GC64: OFF
-    runs-on: [self-hosted, '${{ matrix.RUNNER }}']
+    runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
     name: >
       LuaJIT
-      (${{ matrix.NAME }})
+      (${{ matrix.OS }}/${{ matrix.ARCH }})
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
-- 
2.34.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches]  [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches
@ 2023-01-12 23:23   ` Maxim Kokryashkin via Tarantool-patches
  2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
  2023-01-16  7:53     ` Igor Munkin via Tarantool-patches
  0 siblings, 2 replies; 14+ messages in thread
From: Maxim Kokryashkin via Tarantool-patches @ 2023-01-12 23:23 UTC (permalink / raw)
  To: Igor Munkin; +Cc: tarantool-patches

[-- Attachment #1: Type: text/plain, Size: 4888 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM, except for a few nits below.
 
> 
>>Before the patch the all LuaJIT testing jobs were dispatched to the
>Typo: s/the all/, all/
>>runner with the name given via strategy matrix <RUNNER> entry. However,
>Typo: s/via/via the/
>>more convenient way for dispatching is the triplet of the following
>Typo: s/more/a more/
>>labels:
>>* <matrix.ARCH> to specify the host architecture (i.e. x86_64 or ARM64)
>>* <matrix.OS> to specify the OS family name (either Linux or macOS)
>>* 'self-hosted' to make job dispatch only to the runners from Tarantool
>>  ghacts-shared-* pool and never choose GitHub public resources.
>>
>>With the given triplet the proper runner is chosen for the particular
>>testing flavor.
>>
>>Moreover, the new 'lightweight' and 'regular' labels are also used in
>><runs-on> list, since the new "lightweight" runners have been introduced
>>to ghacts-shared-* pool. There are a couple of LuaJIT tests that
>>requires more memory than provided by "lightweight" runners, so only
>Typo: s/requires/require/
>Typo: s/than/than is/
> 
>>"regular" ones need to be chosen for full LuaJIT testing. At the same
>>time there is no need to use "regular" runner for LuaJIT Static analysis
>>workflow, hence 'lightweight' label is added to <runs-on> list in
>>lint.yml workflow file.
>Shall we create the same patch for the gnumake workflow?
>>
>>Signed-off-by: Igor Munkin < imun@tarantool.org >
>>---
>> .github/workflows/gnumake-builds-testing.yml | 20 ++------------------
>> .github/workflows/lint.yml | 2 +-
>> .github/workflows/testing.yml | 20 ++------------------
>> 3 files changed, 5 insertions(+), 37 deletions(-)
>>
>>diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
>>index ad9d5015..e5f82780 100644
>>--- a/.github/workflows/gnumake-builds-testing.yml
>>+++ b/.github/workflows/gnumake-builds-testing.yml
>>@@ -38,22 +38,6 @@ jobs:
>>         GC64: [ON, OFF]
>>         OS: [Linux, macOS]
>>         include:
>>- - ARCH: ARM64
>>- OS: Linux
>>- NAME: Linux/aarch64
>>- RUNNER: graviton
>>- - ARCH: x86_64
>>- OS: Linux
>>- NAME: Linux/x86_64
>>- RUNNER: ubuntu-20.04-self-hosted
>>- - ARCH: ARM64
>>- OS: macOS
>>- NAME: macOS/M1
>>- RUNNER: macos-11-m1
>>- - ARCH: x86_64
>>- OS: macOS
>>- NAME: macOS/x86_64
>>- RUNNER: macos-11
>>           - BUILDTYPE: Debug
>>             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>>             MAKEBUILDFLAGS: -DLUA_USE_ASSERT -DLUA_USE_APICHECK
>>@@ -70,10 +54,10 @@ jobs:
>>             GC64: OFF
>>           - OS: macOS
>>             GC64: OFF
>>- runs-on: [self-hosted, '${{ matrix.RUNNER }}']
>>+ runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
>>     name: >
>>       LuaJIT
>>- (${{ matrix.NAME }})
>>+ (${{ matrix.OS }}/${{ matrix.ARCH }})
>>       ${{ matrix.BUILDTYPE }}
>>       GC64:${{ matrix.GC64 }}
>>     steps:
>>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
>>index e565144c..02150922 100644
>>--- a/.github/workflows/lint.yml
>>+++ b/.github/workflows/lint.yml
>>@@ -30,7 +30,7 @@ concurrency:
>> 
>> jobs:
>>   test-luacheck:
>>- runs-on: ubuntu-20.04-self-hosted
>>+ runs-on: [self-hosted, lightweight, Linux, x86_64]
>>     name: luacheck
>>     steps:
>>       - uses: actions/checkout@v2.3.4
>>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
>>index 958f8e27..5558e3ea 100644
>>--- a/.github/workflows/testing.yml
>>+++ b/.github/workflows/testing.yml
>>@@ -38,22 +38,6 @@ jobs:
>>         GC64: [ON, OFF]
>>         OS: [Linux, macOS]
>>         include:
>>- - ARCH: ARM64
>>- OS: Linux
>>- NAME: Linux/aarch64
>>- RUNNER: graviton
>>- - ARCH: x86_64
>>- OS: Linux
>>- NAME: Linux/x86_64
>>- RUNNER: ubuntu-20.04-self-hosted
>>- - ARCH: ARM64
>>- OS: macOS
>>- NAME: macOS/M1
>>- RUNNER: macos-11-m1
>>- - ARCH: x86_64
>>- OS: macOS
>>- NAME: macOS/x86_64
>>- RUNNER: macos-11
>>           - BUILDTYPE: Debug
>>             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>>           - BUILDTYPE: Release
>>@@ -63,10 +47,10 @@ jobs:
>>             GC64: OFF
>>           - OS: macOS
>>             GC64: OFF
>>- runs-on: [self-hosted, '${{ matrix.RUNNER }}']
>>+ runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
>>     name: >
>>       LuaJIT
>>- (${{ matrix.NAME }})
>>+ (${{ matrix.OS }}/${{ matrix.ARCH }})
>>       ${{ matrix.BUILDTYPE }}
>>       GC64:${{ matrix.GC64 }}
>>     steps:
>>--
>>2.34.0
>--
>Best regards,
>Maxim Kokryashkin
> 

[-- Attachment #2: Type: text/html, Size: 7612 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
  2023-01-12 23:23   ` Maxim Kokryashkin via Tarantool-patches
@ 2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
  2023-01-16  7:55       ` Igor Munkin via Tarantool-patches
  2023-01-16  7:53     ` Igor Munkin via Tarantool-patches
  1 sibling, 1 reply; 14+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2023-01-13  7:10 UTC (permalink / raw)
  To: Maxim Kokryashkin; +Cc: tarantool-patches

Hi, Igor!

Thanks for the patch!
LGTM, with a single question below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for a few nits below.
>  
> > 
> >>Before the patch the all LuaJIT testing jobs were dispatched to the
> >Typo: s/the all/, all/
> >>runner with the name given via strategy matrix <RUNNER> entry. However,
> >Typo: s/via/via the/
> >>more convenient way for dispatching is the triplet of the following
> >Typo: s/more/a more/
> >>labels:
> >>* <matrix.ARCH> to specify the host architecture (i.e. x86_64 or ARM64)
> >>* <matrix.OS> to specify the OS family name (either Linux or macOS)
> >>* 'self-hosted' to make job dispatch only to the runners from Tarantool
> >>  ghacts-shared-* pool and never choose GitHub public resources.
> >>
> >>With the given triplet the proper runner is chosen for the particular
> >>testing flavor.
> >>
> >>Moreover, the new 'lightweight' and 'regular' labels are also used in
> >><runs-on> list, since the new "lightweight" runners have been introduced
> >>to ghacts-shared-* pool. There are a couple of LuaJIT tests that
> >>requires more memory than provided by "lightweight" runners, so only
> >Typo: s/requires/require/
> >Typo: s/than/than is/
> > 
> >>"regular" ones need to be chosen for full LuaJIT testing. At the same
> >>time there is no need to use "regular" runner for LuaJIT Static analysis
> >>workflow, hence 'lightweight' label is added to <runs-on> list in
> >>lint.yml workflow file.
> >Shall we create the same patch for the gnumake workflow?

I agree here. IMHO, we can use "lightweight" label for gnumake build as
far as it tests only build, so doesn't require a lot of memory.

> >>
> >>Signed-off-by: Igor Munkin < imun@tarantool.org >
> >>---
> >> .github/workflows/gnumake-builds-testing.yml | 20 ++------------------
> >> .github/workflows/lint.yml | 2 +-
> >> .github/workflows/testing.yml | 20 ++------------------
> >> 3 files changed, 5 insertions(+), 37 deletions(-)
> >>
> >>diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
> >>index ad9d5015..e5f82780 100644
> >>--- a/.github/workflows/gnumake-builds-testing.yml
> >>+++ b/.github/workflows/gnumake-builds-testing.yml

<snipped>

> >>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> >>index e565144c..02150922 100644
> >>--- a/.github/workflows/lint.yml
> >>+++ b/.github/workflows/lint.yml

<snipped>

> >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> >>index 958f8e27..5558e3ea 100644
> >>--- a/.github/workflows/testing.yml
> >>+++ b/.github/workflows/testing.yml

<snipped>

> >>--
> >>2.34.0
> >--
> >Best regards,
> >Maxim Kokryashkin
> > 

-- 
Best regards,
Sergey Kaplun

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
  2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
@ 2023-01-16  7:55       ` Igor Munkin via Tarantool-patches
  2023-01-16 12:34         ` Maxim Kokryashkin via Tarantool-patches
  0 siblings, 1 reply; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-16  7:55 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

Sergey,

Thanks for your review!

On 13.01.23, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> LGTM, with a single question below.
> 
> On 13.01.23, Maxim Kokryashkin wrote:
> > 
> > Hi, Igor!
> > Thanks for the patch!
> > LGTM, except for a few nits below.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> >  

<snipped>

> > >>"regular" ones need to be chosen for full LuaJIT testing. At the same
> > >>time there is no need to use "regular" runner for LuaJIT Static analysis
> > >>workflow, hence 'lightweight' label is added to <runs-on> list in
> > >>lint.yml workflow file.
> > >Shall we create the same patch for the gnumake workflow?
> 
> I agree here. IMHO, we can use "lightweight" label for gnumake build as
> far as it tests only build, so doesn't require a lot of memory.

Replied to the Max thread.

> 

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches]  [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
  2023-01-16  7:55       ` Igor Munkin via Tarantool-patches
@ 2023-01-16 12:34         ` Maxim Kokryashkin via Tarantool-patches
  0 siblings, 0 replies; 14+ messages in thread
From: Maxim Kokryashkin via Tarantool-patches @ 2023-01-16 12:34 UTC (permalink / raw)
  To: Igor Munkin; +Cc: tarantool-patches

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]


Hi!
Thanks for the fixes!
LGTM
--
Best regards,
Maxim Kokryashkin
 
  
>Понедельник, 16 января 2023, 11:10 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Sergey,
>
>Thanks for your review!
>
>On 13.01.23, Sergey Kaplun wrote:
>> Hi, Igor!
>>
>> Thanks for the patch!
>> LGTM, with a single question below.
>>
>> On 13.01.23, Maxim Kokryashkin wrote:
>> >
>> > Hi, Igor!
>> > Thanks for the patch!
>> > LGTM, except for a few nits below.
>
>Added your tag:
>| Reviewed-by: Sergey Kaplun < skaplun@tarantool.org >
>
>> >  
>
><snipped>
>
>> > >>"regular" ones need to be chosen for full LuaJIT testing. At the same
>> > >>time there is no need to use "regular" runner for LuaJIT Static analysis
>> > >>workflow, hence 'lightweight' label is added to <runs-on> list in
>> > >>lint.yml workflow file.
>> > >Shall we create the same patch for the gnumake workflow?
>>
>> I agree here. IMHO, we can use "lightweight" label for gnumake build as
>> far as it tests only build, so doesn't require a lot of memory.
>
>Replied to the Max thread.
>
>>
>
><snipped>
>
>>
>> --
>> Best regards,
>> Sergey Kaplun
>
>--
>Best regards,
>IM
 

[-- Attachment #2: Type: text/html, Size: 1878 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
  2023-01-12 23:23   ` Maxim Kokryashkin via Tarantool-patches
  2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
@ 2023-01-16  7:53     ` Igor Munkin via Tarantool-patches
  1 sibling, 0 replies; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-16  7:53 UTC (permalink / raw)
  To: Maxim Kokryashkin; +Cc: tarantool-patches

Max,

Thanks for your review! I've fixed all nits you've left below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for a few nits below.

Added your tag:
| Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>

>  

<snipped>

> >>"regular" ones need to be chosen for full LuaJIT testing. At the same
> >>time there is no need to use "regular" runner for LuaJIT Static analysis
> >>workflow, hence 'lightweight' label is added to <runs-on> list in
> >>lint.yml workflow file.
> >Shall we create the same patch for the gnumake workflow?

We definitely do, *but* the new 'lightweight' label is set only for
x86_64 machines at the moment. It this approach is extended for all
other arch flavors, GNU Make workflow will be updated.

> >>

<snipped>

> >--
> >Best regards,
> >Maxim Kokryashkin
> > 

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
  2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches
@ 2023-01-12 14:51 ` Igor Munkin via Tarantool-patches
  2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
  2023-01-18  9:24 ` [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
  2 siblings, 1 reply; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-12 14:51 UTC (permalink / raw)
  To: Sergey Kaplun, Maxim Kokryashkin; +Cc: tarantool-patches

Considering the changes made in scope of the previous commit, it has
been decided to dispatch LuaJIT integration testing to the runner the
similar way (i.e. by using the pair of <matrix.ARCH> + <matrix.OS>
values). As a result a new job with quite similar strategy matrix[1] is
added as a successor for <test-luajit> job. The new job uses the new
version (with <inputs.arch> and <inputs.os> parameters introduced and
optional <inputs.host> obsolete parameter) of LuaJIT integration
workflow from tarantool/tarantool repo.

[1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow

Signed-off-by: Igor Munkin <imun@tarantool.org>
---
 .github/workflows/testing.yml | 190 ++++++----------------------------
 1 file changed, 30 insertions(+), 160 deletions(-)

diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index 5558e3ea..d707ce83 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -77,173 +77,43 @@ jobs:
         run: cmake --build . --parallel --target test
         working-directory: ${{ env.BUILDDIR }}
 
-  test-tarantool-linux-x86_64-debug-wo-GC64:
-    name: Tarantool (Linux/x86_64) Debug GC64:OFF
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=Debug
-        -DLUAJIT_ENABLE_GC64=OFF
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: OFF
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: Debug
-      host: ubuntu-20.04-self-hosted
-      revision: ${{ github.sha }}
-  test-tarantool-linux-x86_64-debug-w-GC64:
-    name: Tarantool (Linux/x86_64) Debug GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=Debug
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: Debug
-      host: ubuntu-20.04-self-hosted
-      revision: ${{ github.sha }}
-  test-tarantool-linux-x86_64-release-wo-GC64:
-    name: Tarantool (Linux/x86_64) Release GC64:OFF
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=RelWithDebInfo
-        -DLUAJIT_ENABLE_GC64=OFF
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: OFF
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: RelWithDebInfo
-      host: ubuntu-20.04-self-hosted
-      revision: ${{ github.sha }}
-  test-tarantool-linux-x86_64-release-w-GC64:
-    name: Tarantool (Linux/x86_64) Release GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=RelWithDebInfo
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: RelWithDebInfo
-      host: ubuntu-20.04-self-hosted
-      revision: ${{ github.sha }}
-  test-tarantool-linux-aarch64-debug-w-GC64:
-    name: Tarantool (Linux/aarch64) Debug GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=Debug
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: Debug
-      host: graviton
-      revision: ${{ github.sha }}
-  test-tarantool-linux-aarch64-release-w-GC64:
-    name: Tarantool (Linux/aarch64) Release GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=RelWithDebInfo
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: RelWithDebInfo
-      host: graviton
-      revision: ${{ github.sha }}
-  test-tarantool-macos-x86_64-debug-w-GC64:
-    name: Tarantool (macOS/x86_64) Debug GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=Debug
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: Debug
-      host: macos-11
-      revision: ${{ github.sha }}
-  test-tarantool-macos-x86_64-release-w-GC64:
-    name: Tarantool (macOS/x86_64) Release GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=RelWithDebInfo
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: RelWithDebInfo
-      host: macos-11
-      revision: ${{ github.sha }}
-  test-tarantool-macos-m1-debug-w-GC64:
-    name: Tarantool (macOS/M1) Debug GC64:ON
-    needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
-    with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        -DCMAKE_BUILD_TYPE=Debug
-        -DLUAJIT_ENABLE_GC64=ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
-      # FIXME: This parameter is obsolete, drop it when
-      # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: Debug
-      host: macos-11-m1
-      revision: ${{ github.sha }}
-  test-tarantool-macos-m1-release-w-GC64:
-    name: Tarantool (macOS/M1) Release GC64:ON
+
+  test-tarantool:
+    strategy:
+      fail-fast: false
+      matrix:
+        ARCH: [ARM64, x86_64]
+        BUILDTYPE: [Debug, Release]
+        GC64: [ON, OFF]
+        OS: [Linux, macOS]
+        include:
+          - BUILDTYPE: Debug
+            CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug
+          - BUILDTYPE: Release
+            CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
+        exclude:
+          - ARCH: ARM64
+            GC64: OFF
+          - OS: macOS
+            GC64: OFF
+    name: >
+      Tarantool
+      (${{ matrix.OS }}/${{ matrix.ARCH }})
+      ${{ matrix.BUILDTYPE }}
+      GC64:${{ matrix.GC64 }}
     needs: test-luajit
     uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
     with:
       CMAKE_EXTRA_PARAMS: >
         -G Ninja
-        -DCMAKE_BUILD_TYPE=RelWithDebInfo
-        -DLUAJIT_ENABLE_GC64=ON
+        ${{ matrix.CMAKEFLAGS }}
+        -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}
       # FIXME: This parameter is obsolete, drop it when
       # CMAKE_EXTRA_PARAMS is activated.
-      GC64: ON
+      GC64: ${{ matrix.GC64 }}
+      arch: ${{ matrix.ARCH }}
+      os: ${{ matrix.OS }}
       # FIXME: This parameter is obsolete, drop it when
       # CMAKE_EXTRA_PARAMS is activated.
-      buildtype: RelWithDebInfo
-      host: macos-11-m1
+      buildtype: ${{ matrix.BUILDTYPE }}
       revision: ${{ github.sha }}
-- 
2.34.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches]  [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches
@ 2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
  2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches
  2023-01-16  7:58     ` Igor Munkin via Tarantool-patches
  0 siblings, 2 replies; 14+ messages in thread
From: Maxim Kokryashkin via Tarantool-patches @ 2023-01-12 23:27 UTC (permalink / raw)
  To: Igor Munkin; +Cc: tarantool-patches

[-- Attachment #1: Type: text/plain, Size: 8150 bytes --]


Hi!
Thanks for the patch!
LGTM, except for a few nits below.
> 
>>Considering the changes made in scope of the previous commit, it has
>>been decided to dispatch LuaJIT integration testing to the runner the
>>similar way (i.e. by using the pair of <matrix.ARCH> + <matrix.OS>
>>values). As a result a new job with quite similar strategy matrix[1] is
>>added as a successor for <test-luajit> job. The new job uses the new
>>version (with <inputs.arch> and <inputs.os> parameters introduced and
>>optional <inputs.host> obsolete parameter) of LuaJIT integration
>Typo: s/optional/the optional/
>Typo: s/of LuaJIT/of the LuaJIT/
>>workflow from tarantool/tarantool repo.
>Typo: s/from/from the/
>>
>>[1]:  https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow
>>
>>Signed-off-by: Igor Munkin < imun@tarantool.org >
>>---
>> .github/workflows/testing.yml | 190 ++++++----------------------------
>> 1 file changed, 30 insertions(+), 160 deletions(-)
>>
>>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
>>index 5558e3ea..d707ce83 100644
>>--- a/.github/workflows/testing.yml
>>+++ b/.github/workflows/testing.yml
>>@@ -77,173 +77,43 @@ jobs:
>>         run: cmake --build . --parallel --target test
>>         working-directory: ${{ env.BUILDDIR }}
>> 
>>- test-tarantool-linux-x86_64-debug-wo-GC64:
>>- name: Tarantool (Linux/x86_64) Debug GC64:OFF
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=Debug
>>- -DLUAJIT_ENABLE_GC64=OFF
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: OFF
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: Debug
>>- host: ubuntu-20.04-self-hosted
>>- revision: ${{ github.sha }}
>>- test-tarantool-linux-x86_64-debug-w-GC64:
>>- name: Tarantool (Linux/x86_64) Debug GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=Debug
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: Debug
>>- host: ubuntu-20.04-self-hosted
>>- revision: ${{ github.sha }}
>>- test-tarantool-linux-x86_64-release-wo-GC64:
>>- name: Tarantool (Linux/x86_64) Release GC64:OFF
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=RelWithDebInfo
>>- -DLUAJIT_ENABLE_GC64=OFF
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: OFF
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: RelWithDebInfo
>>- host: ubuntu-20.04-self-hosted
>>- revision: ${{ github.sha }}
>>- test-tarantool-linux-x86_64-release-w-GC64:
>>- name: Tarantool (Linux/x86_64) Release GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=RelWithDebInfo
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: RelWithDebInfo
>>- host: ubuntu-20.04-self-hosted
>>- revision: ${{ github.sha }}
>>- test-tarantool-linux-aarch64-debug-w-GC64:
>>- name: Tarantool (Linux/aarch64) Debug GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=Debug
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: Debug
>>- host: graviton
>>- revision: ${{ github.sha }}
>>- test-tarantool-linux-aarch64-release-w-GC64:
>>- name: Tarantool (Linux/aarch64) Release GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=RelWithDebInfo
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: RelWithDebInfo
>>- host: graviton
>>- revision: ${{ github.sha }}
>>- test-tarantool-macos-x86_64-debug-w-GC64:
>>- name: Tarantool (macOS/x86_64) Debug GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=Debug
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: Debug
>>- host: macos-11
>>- revision: ${{ github.sha }}
>>- test-tarantool-macos-x86_64-release-w-GC64:
>>- name: Tarantool (macOS/x86_64) Release GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=RelWithDebInfo
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: RelWithDebInfo
>>- host: macos-11
>>- revision: ${{ github.sha }}
>>- test-tarantool-macos-m1-debug-w-GC64:
>>- name: Tarantool (macOS/M1) Debug GC64:ON
>>- needs: test-luajit
>>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>- with:
>>- CMAKE_EXTRA_PARAMS: >
>>- -G Ninja
>>- -DCMAKE_BUILD_TYPE=Debug
>>- -DLUAJIT_ENABLE_GC64=ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>- # FIXME: This parameter is obsolete, drop it when
>>- # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: Debug
>>- host: macos-11-m1
>>- revision: ${{ github.sha }}
>>- test-tarantool-macos-m1-release-w-GC64:
>>- name: Tarantool (macOS/M1) Release GC64:ON
>>+
>>+ test-tarantool:
>>+ strategy:
>>+ fail-fast: false
>>+ matrix:
>>+ ARCH: [ARM64, x86_64]
>>+ BUILDTYPE: [Debug, Release]
>>+ GC64: [ON, OFF]
>>+ OS: [Linux, macOS]
>>+ include:
>>+ - BUILDTYPE: Debug
>>+ CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug
>>+ - BUILDTYPE: Release
>>+ CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
>>+ exclude:
>>+ - ARCH: ARM64
>>+ GC64: OFF
>>+ - OS: macOS
>>+ GC64: OFF
>>+ name: >
>>+ Tarantool
>>+ (${{ matrix.OS }}/${{ matrix.ARCH }})
>>+ ${{ matrix.BUILDTYPE }}
>>+ GC64:${{ matrix.GC64 }}
>>     needs: test-luajit
>>     uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>>     with:
>>       CMAKE_EXTRA_PARAMS: >
>>         -G Ninja
>>- -DCMAKE_BUILD_TYPE=RelWithDebInfo
>>- -DLUAJIT_ENABLE_GC64=ON
>>+ ${{ matrix.CMAKEFLAGS }}
>>+ -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}
>>       # FIXME: This parameter is obsolete, drop it when
>>       # CMAKE_EXTRA_PARAMS is activated.
>>- GC64: ON
>>+ GC64: ${{ matrix.GC64 }}
>>+ arch: ${{ matrix.ARCH }}
>>+ os: ${{ matrix.OS }}
>>       # FIXME: This parameter is obsolete, drop it when
>>       # CMAKE_EXTRA_PARAMS is activated.
>>- buildtype: RelWithDebInfo
>>- host: macos-11-m1
>>+ buildtype: ${{ matrix.BUILDTYPE }}
>>       revision: ${{ github.sha }}
>>--
>>2.34.0
>--
>Best regards,
>Maxim Kokryashkin

[-- Attachment #2: Type: text/html, Size: 9768 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
  2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
@ 2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches
  2023-01-16  8:00       ` Igor Munkin via Tarantool-patches
  2023-01-16  7:58     ` Igor Munkin via Tarantool-patches
  1 sibling, 1 reply; 14+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2023-01-13  7:16 UTC (permalink / raw)
  To: Maxim Kokryashkin; +Cc: tarantool-patches

Hi, Igor!
Thanks for the patch!
Nice to see matrix in integrational workflow!
LGTM, with a single nit below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi!
> Thanks for the patch!
> LGTM, except for a few nits below.
> > 
> >>Considering the changes made in scope of the previous commit, it has

Typo: s/scope/the scope/

> >>been decided to dispatch LuaJIT integration testing to the runner the
> >>similar way (i.e. by using the pair of <matrix.ARCH> + <matrix.OS>
> >>values). As a result a new job with quite similar strategy matrix[1] is
> >>added as a successor for <test-luajit> job. The new job uses the new
> >>version (with <inputs.arch> and <inputs.os> parameters introduced and
> >>optional <inputs.host> obsolete parameter) of LuaJIT integration
> >Typo: s/optional/the optional/
> >Typo: s/of LuaJIT/of the LuaJIT/
> >>workflow from tarantool/tarantool repo.
> >Typo: s/from/from the/
> >>
> >>[1]:  https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow
> >>
> >>Signed-off-by: Igor Munkin < imun@tarantool.org >
> >>---
> >> .github/workflows/testing.yml | 190 ++++++----------------------------
> >> 1 file changed, 30 insertions(+), 160 deletions(-)
> >>
> >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> >>index 5558e3ea..d707ce83 100644
> >>--- a/.github/workflows/testing.yml
> >>+++ b/.github/workflows/testing.yml

<snipped>

> >>2.34.0
> >--
> >Best regards,
> >Maxim Kokryashkin

-- 
Best regards,
Sergey Kaplun

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
  2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches
@ 2023-01-16  8:00       ` Igor Munkin via Tarantool-patches
  2023-01-16 12:35         ` Maxim Kokryashkin via Tarantool-patches
  0 siblings, 1 reply; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-16  8:00 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

Sergey,

Thanks for your review! I've fixed the nit you've left below.

On 13.01.23, Sergey Kaplun wrote:
> Hi, Igor!
> Thanks for the patch!
> Nice to see matrix in integrational workflow!
> LGTM, with a single nit below.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> 

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches]  [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
  2023-01-16  8:00       ` Igor Munkin via Tarantool-patches
@ 2023-01-16 12:35         ` Maxim Kokryashkin via Tarantool-patches
  0 siblings, 0 replies; 14+ messages in thread
From: Maxim Kokryashkin via Tarantool-patches @ 2023-01-16 12:35 UTC (permalink / raw)
  To: Igor Munkin; +Cc: tarantool-patches

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]


Hi!
Thanks for the fixes!
LGTM.
--
Best regards,
Maxim Kokryashkin
 
 
> 
>>Sergey,
>>
>>Thanks for your review! I've fixed the nit you've left below.
>>
>>On 13.01.23, Sergey Kaplun wrote:
>>> Hi, Igor!
>>> Thanks for the patch!
>>> Nice to see matrix in integrational workflow!
>>> LGTM, with a single nit below.
>>
>>Added your tag:
>>| Reviewed-by: Sergey Kaplun < skaplun@tarantool.org >
>>
>>>
>>
>><snipped>
>>
>>>
>>> --
>>> Best regards,
>>> Sergey Kaplun
>>
>>--
>>Best regards,
>>IM
> 

[-- Attachment #2: Type: text/html, Size: 1144 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
  2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
  2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches
@ 2023-01-16  7:58     ` Igor Munkin via Tarantool-patches
  1 sibling, 0 replies; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-16  7:58 UTC (permalink / raw)
  To: Maxim Kokryashkin; +Cc: tarantool-patches

Max,

Thanks for your review! I've fixed all nits you've left below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi!
> Thanks for the patch!
> LGTM, except for a few nits below.

Added your tag:
| Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>

> > 

<snipped>

> >--
> >Best regards,
> >Maxim Kokryashkin

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI
  2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches
  2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches
@ 2023-01-18  9:24 ` Igor Munkin via Tarantool-patches
  2 siblings, 0 replies; 14+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-01-18  9:24 UTC (permalink / raw)
  To: Sergey Kaplun, Maxim Kokryashkin; +Cc: tarantool-patches

I've checked the patches into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.

On 12.01.23, Igor Munkin wrote:
> This series consists of the two patches caused by recent runner renaming
> activity.
> 
> The first one changes the way workflow is dispatched to the proper
> runner (see the details in the corresponding commit message).
> 
> The second one caused by fluke: due to runner renaming we can't proceed
> to use the previous approach to pass the machine name to LuaJIT
> integration workflow. Hence, we ought to implement something similar
> made in scope of the first patch. Occasionally, I've found that GitHub
> team finally implemented strategy matrix for reusable workflows, so I
> simply made a carbon copy of the <test-luajit> job configuration for
> Tarantool integration testing. As a result the integration workflow is
> also adjusted for the new runner dispatching strategy in scope of
> #8145[1].
> 
> Branch: https://github.com/tarantool/luajit/tree/imun/fix-runner-names
> CI is green: https://github.com/tarantool/luajit/commit/43adedc
> 
> [1]: https://github.com/tarantool/tarantool/pull/8145
> 
> Igor Munkin (2):
>   ci: change runner dispatch for LuaJIT testing
>   ci: use strategy matrix for integration workflow
> 
>  .github/workflows/gnumake-builds-testing.yml |  20 +-
>  .github/workflows/lint.yml                   |   2 +-
>  .github/workflows/testing.yml                | 210 +++----------------
>  3 files changed, 35 insertions(+), 197 deletions(-)
> 
> -- 
> 2.34.0
> 

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-01-18  9:38 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches
2023-01-12 23:23   ` Maxim Kokryashkin via Tarantool-patches
2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
2023-01-16  7:55       ` Igor Munkin via Tarantool-patches
2023-01-16 12:34         ` Maxim Kokryashkin via Tarantool-patches
2023-01-16  7:53     ` Igor Munkin via Tarantool-patches
2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches
2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches
2023-01-16  8:00       ` Igor Munkin via Tarantool-patches
2023-01-16 12:35         ` Maxim Kokryashkin via Tarantool-patches
2023-01-16  7:58     ` Igor Munkin via Tarantool-patches
2023-01-18  9:24 ` [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox