From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergos <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] x64/LJ_GC64: Fix type-check-only variant of SLOAD.
Date: Fri, 16 Dec 2022 11:13:02 +0300 [thread overview]
Message-ID: <Y5wojjUIOhWJp92l@root> (raw)
In-Reply-To: <5F75F00A-7ABB-43F0-86C0-2C91F2AAF78E@tarantool.org>
Hi, Sergos!
Thanks for the review!
On 15.12.22, sergos wrote:
> Hi!
>
> Thanks for the patch!
>
> LGTM with fixes after Max’s review.
>
> Although, as we discussed earlier I would prefer the test has
> `skipcond(not ffi.abi('gc64’), 'test is GC64 only')`
Discussed with Igor offline and agreed to test this code flow for GC64
and non-GC64 modes.
So, ignoring.
>
> regards,
> Sergos
>
<snipped>
>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-12-16 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 8:42 Sergey Kaplun via Tarantool-patches
2022-12-06 7:08 ` Maxim Kokryashkin via Tarantool-patches
2022-12-06 8:49 ` Sergey Kaplun via Tarantool-patches
2022-12-06 13:06 ` Maxim Kokryashkin via Tarantool-patches
2022-12-15 15:49 ` sergos via Tarantool-patches
2022-12-16 8:13 ` Sergey Kaplun via Tarantool-patches [this message]
2023-01-12 14:55 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5wojjUIOhWJp92l@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] x64/LJ_GC64: Fix type-check-only variant of SLOAD.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox