Re: [Tarantool-patches] [PATCH luajit v2] Don't compile math.modf() anymore.

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

I've checked the patches into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.

On 19.08.22, Maxim Kokryashkin wrote:
> From: Mike Pall <mike>
> 
> This commit disables compilation for the `math.modf` function since it's
> rarely used and compiling it in a performant enough way would be
> difficult.
> 
> Part of tarantool/tarantool#7230
> ---
> 
> There are no issues with correctenss of compilation
> of math.modf whatsoever. There are no known issues with it, and all of
> the possible edge cases are handled well both with active
> and inactivve JIT. It's safe to assume that the `properly compiling`
> in the original commit message refers to performance rather than
> correctness.
> 
> PR: https://github.com/tarantool/tarantool/pull/7586
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7230-math-modf
> 
>  src/lib_math.c    |  2 +-
>  src/lj_ffrecord.c | 16 ----------------
>  2 files changed, 1 insertion(+), 17 deletions(-)
> 

<snipped>

> --
> 2.36.1
> 

-- 
Best regards,
IM