From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4D2D2151F29; Mon, 12 Dec 2022 12:57:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D2D2151F29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1670839062; bh=+wV5ipFbJUwpKgG0nX/IocTlZdcFS1xbzhusQFI8tsg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BZH9QPJFZ6w9DTXrigkL7GlDDY1btcj0zhenIg7NVhCMMoBZ/jKD/TKHi8+VEFcCz D4FyCV4lRvao+sOZCwuw3dHkBBbD3fpQPlxyCM3GX68EjqLCItBuiF3drbOIqtoqL0 efTYPjneIYOzd3vxZVrLvJyPpZx5j1+Im9yhqZ6M= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1AE2B151F29 for ; Mon, 12 Dec 2022 12:56:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1AE2B151F29 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1p4fYN-0005p0-EB; Mon, 12 Dec 2022 12:56:55 +0300 Date: Mon, 12 Dec 2022 12:42:58 +0300 To: Maxim Kokryashkin Message-ID: References: <20220818212049.70677-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220818212049.70677-1-m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90D1502B3BE350FE420345CBC5A180DD43DEA314B30AECAB400894C459B0CD1B9789DBECC962E560F7DE4421AFBE44DF69F3F7E04569DA2B9599FBF3E6EA3F319 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371005780D56A98C20EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B6F1F7B995052D5CE92292E2A9F13782206D7C6E30FDDEEFBCC7F00164DA146DAFE8445B8C89999728AA50765F79006375FFD5C25497261569FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C309F854029C6BD0DA117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637427B078F297B269AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340D3A19269BBEBAAFE554C6120B5EB847430BFA73983705F89B681ECD8C7DBB899B689D2E4635F51E1D7E09C32AA3244C7807B587793039ED9C1DB1F7013EC9B2795D98D676DD64D0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCvDLVb3lQJjQY5fzH0MTXg== X-DA7885C5: 715F050E447E227FD83F4351FDA6E2F8BA08C71547D98A89D8BE3ACE58ADA01E262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5F00531463818639C48F2E643D168573DA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] Don't compile math.modf() anymore. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, I've checked the patches into all long-term branches in tarantool/luajit and bumped a new version in master, 2.10 and 1.10. On 19.08.22, Maxim Kokryashkin wrote: > From: Mike Pall > > This commit disables compilation for the `math.modf` function since it's > rarely used and compiling it in a performant enough way would be > difficult. > > Part of tarantool/tarantool#7230 > --- > > There are no issues with correctenss of compilation > of math.modf whatsoever. There are no known issues with it, and all of > the possible edge cases are handled well both with active > and inactivve JIT. It's safe to assume that the `properly compiling` > in the original commit message refers to performance rather than > correctness. > > PR: https://github.com/tarantool/tarantool/pull/7586 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7230-math-modf > > src/lib_math.c | 2 +- > src/lj_ffrecord.c | 16 ---------------- > 2 files changed, 1 insertion(+), 17 deletions(-) > > -- > 2.36.1 > -- Best regards, IM