Re: [Tarantool-patches] [PATCH luajit 1/2] test: relax JIT setup in lj-430-maxirconst test

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Igor!

Thanks for the patch!

LGTM, just several nits regarding the commit message.

On 01.12.22, Igor Munkin wrote:
> JIT engine setup in tarantool-tests/lj-430-maxirconst.test.lua is too
> tight for the build with LUAJIT_ENABLE_CHECKHOOK option enabled.
> Originally test limits <maxirconst> value with 3 for the default IRRef
> constants set: nil, true, false. However, with LUAJIT_ENABLE_CHECKHOOK
> enabled there are three more auxiliary IRRef constants for the internal

Typo: s/enabled/enabled,/

> purposes. Hence, the test is reimplemented the following way:
> * The first trace for the empty function is recorded
> * The number of IRRef constants is obtained via <jit.util.traceinfo>
> * <maxirconst> parameter is set to this value
> * The second trace for the function with a single local variable,
>   initialized with a constant, fails to record
> 
> As a result there is no need to explicitly respect any configuration.

Typo: s/As a result/As a result,/

> 
> Relates to tarantool/tarantool#7762
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>  .../lj-430-maxirconst.test.lua                | 23 +++++++++++--------
>  1 file changed, 14 insertions(+), 9 deletions(-)

<snipped>

> 2.34.0
> 

-- 
Best regards,
Sergey Kaplun