Re: [Tarantool-patches] [PATCH luajit v4 5/8] OSX/ARM64: Disable unwind info.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maksim!
Thanks for the patch!

LGTM, with a single nit regarding the commit message.

On 28.10.22, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
> 
> See #698.
> 
> (cherry picked from commit 78350a2565e1cf1102bcd25be406f02953d4dd3b)
> 
> External unwinding support is already disabled for OSX on ARM64

Typo: s/on ARM64 platform/on the ARM64 platform/

> platform so there is no point in generation of incorrect unwind
> info for it. This patch disables that generation for the commit
> history match, and it will be re-enabled in the next commit,
> which contains the fix for the issue.
> 
> Maxim Kokryashkin:
> * added the description for the problem
> 
> Needed for tarantool/tarantool#6096
> Part of tarantool/tarantool#7230
> ---
>  src/vm_arm64.dasc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc
> index ad57bca3..ccfa72bd 100644
> --- a/src/vm_arm64.dasc
> +++ b/src/vm_arm64.dasc

<snipped>

> -- 
> 2.37.0 (Apple Git-136)
> 

-- 
Best regards,
Sergey Kaplun