Re: [Tarantool-patches] [PATCH luajit] GC64: enable sysprof support

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the patch!

LGTM, with a single nit regarding the commit message.

On 11.11.22, Maxim Kokryashkin wrote:
> This patch reverts changes introduced via commit
> 71e7020637bb15024ceb7e93ce66b61870567339 ('GC64: disable
> sysprof support'), fixing the incorrect behavior in vm

Typo: s/in vm/in the VM/

> by adding the `LJ_HASSYSPROF` flag to the DynASM flags.

Nice catch!

> 
> Resolves tarantool/tarantool#7919
> Related to tarantool/tarantool#781
> ---
> Issue: https://github.com/tarantool/tarantool/issues/7919
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7919-sysprof-gc64
> PR: https://github.com/tarantool/tarantool/pull/7922
> 
>  cmake/SetDynASMFlags.cmake                    |  5 +++
>  src/lj_arch.h                                 |  2 +-
>  src/lj_obj.h                                  |  2 +
>  src/vm_x64.dasc                               | 42 ++++++++++++++-----
>  src/vm_x86.dasc                               |  8 ++++
>  .../misclib-sysprof-capi.test.lua             |  7 ++--
>  .../misclib-sysprof-lapi.test.lua             |  5 +--
>  7 files changed, 52 insertions(+), 19 deletions(-)
> 
> diff --git a/cmake/SetDynASMFlags.cmake b/cmake/SetDynASMFlags.cmake

<snipped>

> diff --git a/src/lj_arch.h b/src/lj_arch.h

<snipped>

> diff --git a/src/lj_obj.h b/src/lj_obj.h

<snipped>

> diff --git a/src/vm_x64.dasc b/src/vm_x64.dasc

<snipped>

> diff --git a/src/vm_x86.dasc b/src/vm_x86.dasc

<snipped>

> diff --git a/test/tarantool-tests/misclib-sysprof-capi.test.lua b/test/tarantool-tests/misclib-sysprof-capi.test.lua

<snipped>

> diff --git a/test/tarantool-tests/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/misclib-sysprof-lapi.test.lua

<snipped>

> -- 
> 2.38.0
> 

-- 
Best regards,
Sergey Kaplun