* [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
@ 2023-02-06 7:17 Sergey Kaplun via Tarantool-patches
2023-02-06 11:00 ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 9:34 ` Igor Munkin via Tarantool-patches
0 siblings, 2 replies; 4+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2023-02-06 7:17 UTC (permalink / raw)
To: Sergey Ostanevich, Maxim Kokryashkin; +Cc: tarantool-patches
This commit adds the build with the aforementioned option to test
on x86_64 and arm64 architectures to exotic build matrix.
---
Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook
Workflow example: https://github.com/tarantool/luajit/actions/runs/4101136217
.github/workflows/exotic-builds-testing.yml | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index cd0c14d7..aaf4f9f6 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -29,13 +29,14 @@ concurrency:
cancel-in-progress: true
jobs:
- test-x86_64-exotic:
+ test-exotic:
strategy:
fail-fast: false
matrix:
BUILDTYPE: [Debug, Release]
+ ARCH: [ARM64, x86_64]
GC64: [ON, OFF]
- FLAVOR: [dualnum]
+ FLAVOR: [dualnum, checkhook]
include:
- BUILDTYPE: Debug
CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -43,10 +44,16 @@ jobs:
CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
- FLAVOR: dualnum
FLAVORFLAGS: -DLUAJIT_NUMMODE=2
- runs-on: [self-hosted, regular, Linux, x86_64]
+ - FLAVOR: checkhook
+ FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON
+ exclude:
+ # DUALNUM is default for ARM64, no need for additional testing.
+ - FLAVOR: dualnum
+ ARCH: ARM64
+ runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
name: >
LuaJIT ${{ matrix.FLAVOR }}
- (Linux/x86_64)
+ (Linux/${{ matrix.ARCH }})
${{ matrix.BUILDTYPE }}
GC64:${{ matrix.GC64 }}
steps:
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
2023-02-06 7:17 [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix Sergey Kaplun via Tarantool-patches
@ 2023-02-06 11:00 ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 9:34 ` Igor Munkin via Tarantool-patches
1 sibling, 0 replies; 4+ messages in thread
From: Maxim Kokryashkin via Tarantool-patches @ 2023-02-06 11:00 UTC (permalink / raw)
To: Sergey Kaplun; +Cc: tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]
Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>
>>This commit adds the build with the aforementioned option to test
>>on x86_64 and arm64 architectures to exotic build matrix.
>>---
>>
>>Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook
>>Workflow example: https://github.com/tarantool/luajit/actions/runs/4101136217
>>
>> .github/workflows/exotic-builds-testing.yml | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>
>>diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
>>index cd0c14d7..aaf4f9f6 100644
>>--- a/.github/workflows/exotic-builds-testing.yml
>>+++ b/.github/workflows/exotic-builds-testing.yml
>>@@ -29,13 +29,14 @@ concurrency:
>> cancel-in-progress: true
>>
>> jobs:
>>- test-x86_64-exotic:
>>+ test-exotic:
>> strategy:
>> fail-fast: false
>> matrix:
>> BUILDTYPE: [Debug, Release]
>>+ ARCH: [ARM64, x86_64]
>> GC64: [ON, OFF]
>>- FLAVOR: [dualnum]
>>+ FLAVOR: [dualnum, checkhook]
>> include:
>> - BUILDTYPE: Debug
>> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>>@@ -43,10 +44,16 @@ jobs:
>> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
>> - FLAVOR: dualnum
>> FLAVORFLAGS: -DLUAJIT_NUMMODE=2
>>- runs-on: [self-hosted, regular, Linux, x86_64]
>>+ - FLAVOR: checkhook
>>+ FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON
>>+ exclude:
>>+ # DUALNUM is default for ARM64, no need for additional testing.
>>+ - FLAVOR: dualnum
>>+ ARCH: ARM64
>>+ runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
>> name: >
>> LuaJIT ${{ matrix.FLAVOR }}
>>- (Linux/x86_64)
>>+ (Linux/${{ matrix.ARCH }})
>> ${{ matrix.BUILDTYPE }}
>> GC64:${{ matrix.GC64 }}
>> steps:
>>--
>>2.34.1
>
[-- Attachment #2: Type: text/html, Size: 3405 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
2023-02-06 7:17 [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix Sergey Kaplun via Tarantool-patches
2023-02-06 11:00 ` Maxim Kokryashkin via Tarantool-patches
@ 2023-02-13 9:34 ` Igor Munkin via Tarantool-patches
2023-02-13 9:37 ` Sergey Kaplun via Tarantool-patches
1 sibling, 1 reply; 4+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-02-13 9:34 UTC (permalink / raw)
To: Sergey Kaplun; +Cc: tarantool-patches
Sergey,
Thanks for your patch! The only change I suggest is splitting this one
into two separate patches: one for the matrix and another for CHECKHOOK
job. Otherwise, LGTM.
--
Best regards,
IM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
2023-02-13 9:34 ` Igor Munkin via Tarantool-patches
@ 2023-02-13 9:37 ` Sergey Kaplun via Tarantool-patches
0 siblings, 0 replies; 4+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2023-02-13 9:37 UTC (permalink / raw)
To: Igor Munkin; +Cc: tarantool-patches
Hi, Igor!
Thanks for the review!
On 13.02.23, Igor Munkin wrote:
> Sergey,
>
> Thanks for your patch! The only change I suggest is splitting this one
> into two separate patches: one for the matrix and another for CHECKHOOK
> job. Otherwise, LGTM.
Done! You can see it in the following ML thread [1].
Branch is force pushed.
>
> --
> Best regards,
> IM
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2023-February/027399.html
--
Best regards,
Sergey Kaplun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-13 9:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-06 7:17 [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix Sergey Kaplun via Tarantool-patches
2023-02-06 11:00 ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 9:34 ` Igor Munkin via Tarantool-patches
2023-02-13 9:37 ` Sergey Kaplun via Tarantool-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox