From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 4/5] OSX: Disable unreliable assertion for external frame unwinding. Date: Thu, 16 Feb 2023 09:50:41 +0300 [thread overview] Message-ID: <Y+3SQTSEnIwJxebv@root> (raw) In-Reply-To: <0f233a6e094d1552b0ac416ec1af4c87610f995f.1676413474.git.m.kokryashkin@tarantool.org> Hi, Maxim! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 15.02.23, Maxim Kokryashkin wrote: > From: Mike Pall <mike> > > (cherry-picked from commit be251d9149b386ca0d4b51106be14366c5dbdf14) > > `_Unwind_Find_FDE()` will locate the FDE if the pc is in some > function that has an associated FDE. Note, Mac OS X 10.6 and > later, introduces "compact unwind info" which the runtime uses in > preference to DWARF unwind info. This function will only work if > the target function has an FDE but no compact unwind info. Please, mention that our VM has "compact unwind info" (see `BUILD_machasm` case), so this is the reason why DWARF unwind info isn't found by unwinder's `_Unwind_Find_FDE()`. Does it mean, that all `pcall()` related tests will fail on macOS with enabled external unwinder (this is why we don't need a test case)? > > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#7745 I suppose we should add: | Part of tarantool/tarantool#8069 > --- > src/lj_err.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/lj_err.c b/src/lj_err.c > index f6200233..975b5621 100644 > --- a/src/lj_err.c > +++ b/src/lj_err.c <snipped> > -- > 2.39.0 > -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2023-02-16 6:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-14 22:30 [Tarantool-patches] [PATCH luajit 0/5] jit: add exception unwinding Maxim Kokryashkin via Tarantool-patches 2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 1/5] test: disable `lj-603-snap-restore` test Maxim Kokryashkin via Tarantool-patches 2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 2/5] Handle on-trace OOM errors from helper functions Maxim Kokryashkin via Tarantool-patches 2023-02-16 11:36 ` Sergey Kaplun via Tarantool-patches 2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 3/5] Disable unreliable assertion for external frame unwinding Maxim Kokryashkin via Tarantool-patches 2023-02-16 6:58 ` Sergey Kaplun via Tarantool-patches 2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 4/5] OSX: " Maxim Kokryashkin via Tarantool-patches 2023-02-16 6:50 ` Sergey Kaplun via Tarantool-patches [this message] 2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 5/5] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc Maxim Kokryashkin via Tarantool-patches 2023-02-16 7:03 ` Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y+3SQTSEnIwJxebv@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 4/5] OSX: Disable unreliable assertion for external frame unwinding.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox