Re: [Tarantool-patches] [PATCH luajit 3/5] test: introduce test:skipall TAP helper

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Igor!

Thanks for the patch!
LGTM, just a few nits regarding the commit message.

On 27.02.23, Igor Munkin wrote:
> Sometimes one need to skip all tests in the script. TAP13 protocol

Typo: s/need/needs/

> supports this via the following line:
> | 1..0 # SKIP <reason>
> 
> Within this commit <test:skipall> helper is introduced that yields the
> aforementined line to the TAP consumer and exits the test script. It's

Typo: s/aforementined/aforementioned/

> worth to mention, that skipall helper is implemented only for root (i.e.
> test with no parent) tests and subtests are not supported at the moment.
> The corresponding assertion with FIXME reason is added to <finalize>.
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>  test/tarantool-tests/tap.lua | 23 ++++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/test/tarantool-tests/tap.lua b/test/tarantool-tests/tap.lua
> index a1f54d20..92d59ce9 100644
> --- a/test/tarantool-tests/tap.lua
> +++ b/test/tarantool-tests/tap.lua

<snipped>


-- 
Best regards,
Sergey Kaplun