Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 4/5] test: introduce test:skiprest TAP helper
Date: Mon, 27 Feb 2023 12:56:15 +0300	[thread overview]
Message-ID: <Y/x+P9NOX8uFfDa2@root> (raw)
In-Reply-To: <73121e49f78fb8fee355ce09a80f77ef12046e67.1677236706.git.imun@tarantool.org>

Hi, Igor!

Thanks for the patch!
LGTM, except a single nit regarding the commit message.

On 27.02.23, Igor Munkin wrote:
> Sometimes one need to skip the remaining tests in the script. There is

Typo: s/need/needs/

> no special stub in TAP13 protocol for this, but this could be done via
> skipping all the remaining planned tests.
> 
> Within this commit <test:skiprest> helper is introduced that calls
> <test:skip> (planned - total) times and exits the test script. As for
> the previous commit it's worth to mention, that skiprest helper is
> implemented only for root (i.e. test with no parent) tests and subtests
> are not supported at the moment. The corresponding assertion with FIXME
> reason can be found in <finalize> routine.
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>

<snipped>

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2023-02-27  9:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  9:07 [Tarantool-patches] [PATCH luajit 0/5] Tarantool tests enhancements Igor Munkin via Tarantool-patches
2023-02-27  9:07 ` [Tarantool-patches] [PATCH luajit 1/5] ci: use LuaJIT-test target in testing workflows Igor Munkin via Tarantool-patches
2023-02-27  9:41   ` Sergey Kaplun via Tarantool-patches
2023-02-28  7:42   ` Maxim Kokryashkin via Tarantool-patches
2023-02-27  9:07 ` [Tarantool-patches] [PATCH luajit 2/5] test: stop using utils.selfrun in tests Igor Munkin via Tarantool-patches
2023-02-27 10:08   ` Sergey Kaplun via Tarantool-patches
2023-02-27 18:04     ` Igor Munkin via Tarantool-patches
2023-02-28  7:46       ` Maxim Kokryashkin via Tarantool-patches
2023-02-27  9:07 ` [Tarantool-patches] [PATCH luajit 3/5] test: introduce test:skipall TAP helper Igor Munkin via Tarantool-patches
2023-02-27  9:51   ` Sergey Kaplun via Tarantool-patches
2023-02-27 18:04     ` Igor Munkin via Tarantool-patches
2023-02-28  7:51   ` Maxim Kokryashkin via Tarantool-patches
2023-02-28 16:26     ` Igor Munkin via Tarantool-patches
2023-02-27  9:07 ` [Tarantool-patches] [PATCH luajit 4/5] test: introduce test:skiprest " Igor Munkin via Tarantool-patches
2023-02-27  9:56   ` Sergey Kaplun via Tarantool-patches [this message]
2023-02-27 18:04     ` Igor Munkin via Tarantool-patches
2023-02-28  7:55   ` Maxim Kokryashkin via Tarantool-patches
2023-02-28 16:26     ` Igor Munkin via Tarantool-patches
2023-02-27  9:07 ` [Tarantool-patches] [PATCH luajit 5/5] test: make skipcond helper more convenient Igor Munkin via Tarantool-patches
2023-02-27 10:01   ` Sergey Kaplun via Tarantool-patches
2023-02-28  8:10   ` Maxim Kokryashkin via Tarantool-patches
2023-03-02 17:07 ` [Tarantool-patches] [PATCH luajit 0/5] Tarantool tests enhancements Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/x+P9NOX8uFfDa2@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 4/5] test: introduce test:skiprest TAP helper' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox