From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Alex Khatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/3] sql: delete unused code
Date: Tue, 2 Oct 2018 16:36:41 +0300 [thread overview]
Message-ID: <FF97634F-5119-485D-8C2E-A2BD5109DF4D@tarantool.org> (raw)
In-Reply-To: <80b97605c05e8de841b476627ca52eda60d77b0e.1538476785.git.avkhatskevich@tarantool.org>
> diff --git a/src/box/sql/main.c b/src/box/sql/main.c
> index 782f99452..3a01f1207 100644
> --- a/src/box/sql/main.c
> +++ b/src/box/sql/main.c
> @@ -483,105 +483,6 @@ setupLookaside(sqlite3 * db, void *pBuf, int sz, int cnt)
> return SQLITE_OK;
> }
>
> -/*
> - * Free up as much memory as we can from the given database
> - * connection.
> - */
> -int
> -sqlite3_db_release_memory(sqlite3 * db)
You forgot to delete function declaration from sqliteInt.h
> @@ -712,12 +613,6 @@ sqlite3_close(sqlite3 * db)
> return sqlite3Close(db, 0);
> }
>
> -int
> -sqlite3_close_v2(sqlite3 * db)
> -{
> - return sqlite3Close(db, 1);
> -}
You deleted not all mentions of sqlite3_close_v2(), just grep it.
next prev parent reply other threads:[~2018-10-02 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 10:48 [tarantool-patches] [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas AKhatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 1/3] sql: delete unused code AKhatskevich
2018-10-02 13:36 ` n.pettik [this message]
2018-10-04 15:16 ` [tarantool-patches] " Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 2/3] sql: delete foreign_keys pragma AKhatskevich
2018-10-02 13:36 ` [tarantool-patches] " n.pettik
2018-10-04 15:16 ` Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 3/3] sql: delete ignore_check_constraints pragma AKhatskevich
2018-10-02 13:36 ` [tarantool-patches] " n.pettik
2018-10-04 15:16 ` Alex Khatskevich
2018-10-04 16:27 ` [tarantool-patches] Re: [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas n.pettik
2018-10-05 7:15 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF97634F-5119-485D-8C2E-A2BD5109DF4D@tarantool.org \
--to=korablev@tarantool.org \
--cc=avkhatskevich@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/3] sql: delete unused code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox