Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: allow ON CONFLICT REPLACE only for PK index
Date: Fri, 11 May 2018 21:18:55 +0300	[thread overview]
Message-ID: <FED0269C-1826-43B9-AE3E-7E514CFA5CF1@tarantool.org> (raw)
In-Reply-To: <20180511060116.pdegorozkbvjccwu@tarantool.org>


> On 11 May 2018, at 09:01, Kirill Yukhin <kyukhin@tarantool.org> wrote:
> 
> Hello Bulat, Nikita,
> On 04 мая 02:39, n.pettik wrote:
>> I am OK with this patch.
>> I have fixed a few minor codestyle violations and
>> rebased to fresh 2.0
> The patch makes sql/on-conflict test fail.
> Could you pls fix it.
> 
> --
> Regards, Kirill Yukhin

Well, I don’t have such troubles, everything works fine.
Are you sure that you are using last version?
Branch is bn/gh-2963-proper-replace

      reply	other threads:[~2018-05-11 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22  7:37 [tarantool-patches] " Bulat Niatshin
2018-05-03 23:39 ` [tarantool-patches] " n.pettik
2018-05-11  6:01   ` Kirill Yukhin
2018-05-11 18:18     ` n.pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FED0269C-1826-43B9-AE3E-7E514CFA5CF1@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: allow ON CONFLICT REPLACE only for PK index' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox