Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Alex Khatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/3] sql: delete foreign_keys pragma
Date: Tue, 2 Oct 2018 16:36:49 +0300	[thread overview]
Message-ID: <FE3E4149-1325-4D8D-8833-2EDC5DD961C1@tarantool.org> (raw)
In-Reply-To: <df0aa200035d6e192abcaa65fdb47195eee8c41c.1538476785.git.avkhatskevich@tarantool.org>


> diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h
> index e9c15dbb3..b2d527834 100644
> --- a/src/box/sql/sqliteInt.h
> +++ b/src/box/sql/sqliteInt.h
> @@ -1562,7 +1562,7 @@ struct sqlite3 {
> #define SQLITE_ReadUncommitted 0x0004000	/* For shared-cache mode */
> #define SQLITE_ReverseOrder   0x00020000	/* Reverse unordered SELECTs */
> #define SQLITE_RecTriggers    0x00040000	/* Enable recursive triggers */
> -#define SQLITE_ForeignKeys    0x00080000	/* Enforce foreign key constraints  */
> +/*                            0x00080000	   Free bit */

Don’t do this. It is easy to check that this bit is really free manually.

  reply	other threads:[~2018-10-02 13:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 10:48 [tarantool-patches] [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas AKhatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 1/3] sql: delete unused code AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 2/3] sql: delete foreign_keys pragma AKhatskevich
2018-10-02 13:36   ` n.pettik [this message]
2018-10-04 15:16     ` [tarantool-patches] " Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 3/3] sql: delete ignore_check_constraints pragma AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-04 16:27 ` [tarantool-patches] Re: [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas n.pettik
2018-10-05  7:15 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FE3E4149-1325-4D8D-8833-2EDC5DD961C1@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=avkhatskevich@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/3] sql: delete foreign_keys pragma' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox