From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v5 4/6] schema: add new system space for CHECK constraints
Date: Sun, 26 May 2019 16:31:17 +0300 [thread overview]
Message-ID: <FCB48363-06FB-4985-A289-D8D33835B989@tarantool.org> (raw)
In-Reply-To: <c48a4885-faa3-77b0-f2e8-69c4e24a43f9@tarantool.org>
>> diff --git a/src/box/sql/parse.y b/src/box/sql/parse.y
>> index f241b8d52..e93dfe751 100644
>> --- a/src/box/sql/parse.y
>> +++ b/src/box/sql/parse.y
>> @@ -297,7 +297,7 @@ ccons ::= check_constraint_def .
>>
>> check_constraint_def ::= cconsname(N) CHECK LP expr(X) RP. {
>> create_ck_def_init(&pParse->create_ck_def, &N, &X);
>> - sql_add_check_constraint(pParse);
>> + sql_create_check_contraint(pParse);
>
> 9. What was a motivation of this rename? As I understand,
> we can add many CHECK constraints in one CREATE TABLE. We
> do not 'create' one single CHECK, we add multiple ones. Please,
> keep the old name.
It was me who asked for this refactoring. We already have
sql_create_foreign_key() and sql_create_index(), so my
intention was to keep naming consistent.
next prev parent reply other threads:[~2019-05-26 13:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 10:19 [tarantool-patches] [PATCH v5 0/6] box: run checks on insertions in LUA spaces Kirill Shcherbatov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 1/6] sql: introduce a new method to bind a pointer Kirill Shcherbatov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 2/6] sql: refactor OP_Column vdbe instruction Kirill Shcherbatov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 3/6] sql: introduce tuple_fetcher class Kirill Shcherbatov
2019-05-26 12:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-05-31 19:45 ` Konstantin Osipov
2019-05-31 19:50 ` Kirill Shcherbatov
2019-05-31 22:36 ` Vladislav Shpilevoy
2019-06-01 5:45 ` Konstantin Osipov
2019-06-02 18:50 ` Kirill Shcherbatov
2019-06-03 21:15 ` Vladislav Shpilevoy
2019-06-05 6:47 ` Konstantin Osipov
2019-06-05 6:48 ` Konstantin Osipov
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 4/6] schema: add new system space for CHECK constraints Kirill Shcherbatov
2019-05-26 12:06 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-26 13:31 ` n.pettik [this message]
2019-05-26 13:32 ` Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-06-03 21:15 ` Vladislav Shpilevoy
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 5/6] box: run check constraint tests on space alter Kirill Shcherbatov
2019-05-26 12:07 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-06-03 21:15 ` Vladislav Shpilevoy
2019-05-23 10:19 ` [tarantool-patches] [PATCH v5 6/6] box: user-friendly interface to manage ck constraints Kirill Shcherbatov
2019-05-26 12:07 ` [tarantool-patches] " Vladislav Shpilevoy
2019-05-31 13:45 ` Kirill Shcherbatov
2019-06-03 21:15 ` [tarantool-patches] Re: [PATCH v5 0/6] box: run checks on insertions in LUA spaces Vladislav Shpilevoy
2019-06-04 7:21 ` Kirill Shcherbatov
2019-06-04 18:59 ` Vladislav Shpilevoy
2019-06-06 11:58 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FCB48363-06FB-4985-A289-D8D33835B989@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v5 4/6] schema: add new system space for CHECK constraints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox