From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL Date: Wed, 24 Jul 2019 16:23:42 +0300 [thread overview] Message-ID: <F05B7622-DD90-4826-BB5C-2B6D9487DAC4@tarantool.org> (raw) In-Reply-To: <bc55c527-0952-3d1b-d16e-4de844869927@tarantool.org> Thanks, the only dubious nit I can spot: should we set initiateTTrans for DDL operations which consist of one box operations? Like: create index, drop index, create trigger, drop trigger, drop constraint etc For instance, we don’t set it for TRUNCATE stmt. The only two operations which require starting transactions are CREATE TABLE and RENAME. Btw, when checking results of RENAME I’d also check that operation (update of ‘CREATE TRIGGER …' string) performed on _trigger has been committed/rollbacked.
next prev parent reply other threads:[~2019-07-24 13:23 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-19 22:49 [tarantool-patches] [PATCH 0/2] SQL TXN DDL Vladislav Shpilevoy 2019-07-19 22:49 ` [tarantool-patches] [PATCH 1/2] alter: do not access space in drop ck commit trigger Vladislav Shpilevoy 2019-07-19 22:49 ` [tarantool-patches] [PATCH 2/2] sql: transactional DDL Vladislav Shpilevoy 2019-07-20 7:42 ` [tarantool-patches] " Konstantin Osipov 2019-07-20 14:02 ` Vladislav Shpilevoy 2019-07-20 15:16 ` Konstantin Osipov 2019-07-22 13:59 ` n.pettik 2019-07-22 21:35 ` Vladislav Shpilevoy 2019-07-24 13:23 ` n.pettik [this message] 2019-07-24 20:58 ` Vladislav Shpilevoy 2019-07-25 12:04 ` n.pettik 2019-07-31 13:19 ` [tarantool-patches] Re: [PATCH 0/2] SQL TXN DDL Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F05B7622-DD90-4826-BB5C-2B6D9487DAC4@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox