Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: szudin@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v4 1/2] sql: remove useless pragmas
Date: Tue, 12 Feb 2019 20:05:51 +0300	[thread overview]
Message-ID: <EEF285E4-083D-4DC7-9649-C7D96A5C1615@tarantool.org> (raw)
In-Reply-To: <20190212073151.27230-1-szudin@tarantool.org>

When you send patch consisting from >= 2 commits,
you should organise it as patch-set with covering letter:
https://tarantool.io/en/doc/2.1/dev_guide/developer_guidelines/

Quote:

‘''
If there are multiple patches you want to submit in one go (e.g. this is a big feature which requires some preparatory patches to be committed first), you should send each patch in a separate email in reply to a cover letter. To format a patch series accordingly, pass the following options to git format-patch:
…
‘’'


> On 12 Feb 2019, at 10:31, Stanislav Zudin <szudin@tarantool.org> wrote:
> 
> The pragmas "query_only" and "read_uncommitted" didn't affect anything
> and were removed.
> Fixed an error in pragma index_list which caused a segmantation fault.
> pragma sql_default_engine accepts only strings.
> Thus pragma sql_default_engine('memtx') is a well-formed command,
> while pragma sql_default_engine(memtx) or
> pragma sql_default_engine("memtx") are considered as ill-formed and
> raise an error.
> 
> Closes #3733

You twice close issue - in both commits.
Please, do it only in the last one.

The rest in this patch is OK.

  parent reply	other threads:[~2019-02-12 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12  7:31 [tarantool-patches] " Stanislav Zudin
2019-02-12  7:31 ` [tarantool-patches] [PATCH v4 2/2] sql: remove busy handler Stanislav Zudin
2019-02-12 17:05   ` [tarantool-patches] " n.pettik
2019-02-13  7:10     ` Stanislav Zudin
2019-02-13 12:54       ` n.pettik
2019-02-12 17:05 ` n.pettik [this message]
2019-02-18 10:28 ` [tarantool-patches] Re: [PATCH v4 1/2] sql: remove useless pragmas Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EEF285E4-083D-4DC7-9649-C7D96A5C1615@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=szudin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v4 1/2] sql: remove useless pragmas' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox