From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: szudin@tarantool.org
Subject: [tarantool-patches] Re: [PATCH] sql: remove useless pragmas
Date: Fri, 8 Feb 2019 17:03:39 +0300 [thread overview]
Message-ID: <EE20AA6E-8270-4010-9D91-C673734B3C12@tarantool.org> (raw)
In-Reply-To: <cdb95b87-4b6a-f50b-dbd8-58fb5af116ac@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
> On 8 Feb 2019, at 13:17, Stanislav Zudin <szudin@tarantool.org> wrote:
>
> On 06.02.2019 16:21, n.pettik wrote:
>>
>>> On 6 Feb 2019, at 15:18, Stanislav Zudin <szudin@tarantool.org <mailto:szudin@tarantool.org>> wrote:
>>>
>>> The pragmas "query_only" and "read_uncommitted" didn't affect anything and were removed.
>> Nit: please, fit commit message into 72 symbols.
> Mea culpa
>>
>> What about “busy_timeout”? As I see from code it is also useless.
>> It may require to delete some code more code.
> It calls sqlite_busy_handler. Does this feature work?
No, it doesn’t. You can remove it in a separate patch.
[-- Attachment #2: Type: text/html, Size: 4171 bytes --]
next prev parent reply other threads:[~2019-02-08 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 12:18 [tarantool-patches] " Stanislav Zudin
2019-02-06 13:21 ` [tarantool-patches] " n.pettik
2019-02-08 10:17 ` Stanislav Zudin
2019-02-08 14:03 ` n.pettik [this message]
2019-02-08 16:46 ` Stanislav Zudin
2019-02-10 22:54 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE20AA6E-8270-4010-9D91-C673734B3C12@tarantool.org \
--to=korablev@tarantool.org \
--cc=szudin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove useless pragmas' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox