From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Ivan Koptelov <ivan.koptelov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: LIKE/LENGTH process '\0'
Date: Tue, 26 Feb 2019 20:50:07 +0300 [thread overview]
Message-ID: <ED6A8E46-356B-4ECB-B542-C3942FDFFC03@tarantool.org> (raw)
In-Reply-To: <C345EB6B-C67C-4CCE-AD76-210C3A18EE8D@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
> On 26 Feb 2019, at 16:33, i.koptelov <ivan.koptelov@tarantool.org> wrote:
>> On 25 Feb 2019, at 18:10, n.pettik <korablev@tarantool.org> wrote:
>>
>> That’s I was talking about. But using the macros with the same
>> name as in utf library doesn’t look like a good pattern. Yep, you
>> can use define guards like:
>>
>> #ifdef U8_COUNT_TRAIL_BYTES_UNSAFE
>> #undef U8_COUNT_TRAIL_BYTES_UNSAFE
>> #endif
>> #define U8_COUNT_TRAIL_BYTES_UNSAFE
>>
>> But I’d rather just give it another name.
>> Hence, taking into account comment below,
>> we are going to substitute SQL_SKIP_UTF8() with
>> implementation borrowed from icu library.
> I changed the names to SQL_UTF8_FWD_1_UNSAFE and
> SQL_UTF8_COUNT_TRAIL_BYTES_UNSAFE.
Won’t bother you with portion of minor comments.
I’ve pushed them, take a look. If they are OK, just
squash (but don’t squash last commit) them and
patch will be OK as well.
Also, I’ve fixed a bit commit message. Add please
doc request which includes user-visible changes.
[-- Attachment #2: Type: text/html, Size: 3195 bytes --]
next prev parent reply other threads:[~2019-02-26 17:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 9:56 [tarantool-patches] " Ivan Koptelov
2019-01-29 16:35 ` [tarantool-patches] " n.pettik
2019-02-04 12:34 ` Ivan Koptelov
2019-02-05 13:50 ` n.pettik
2019-02-07 15:14 ` i.koptelov
2019-02-11 13:15 ` n.pettik
2019-02-13 15:46 ` i.koptelov
2019-02-14 12:57 ` n.pettik
2019-02-20 13:54 ` i.koptelov
2019-02-20 15:47 ` i.koptelov
2019-02-20 16:04 ` n.pettik
2019-02-20 18:08 ` Vladislav Shpilevoy
2019-02-20 19:24 ` i.koptelov
2019-02-22 12:59 ` n.pettik
2019-02-25 11:09 ` i.koptelov
2019-02-25 15:10 ` n.pettik
2019-02-26 13:33 ` i.koptelov
2019-02-26 17:50 ` n.pettik [this message]
2019-02-26 18:44 ` i.koptelov
2019-02-26 20:16 ` Vladislav Shpilevoy
2019-03-04 11:59 ` i.koptelov
2019-03-04 15:30 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED6A8E46-356B-4ECB-B542-C3942FDFFC03@tarantool.org \
--to=korablev@tarantool.org \
--cc=ivan.koptelov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: LIKE/LENGTH process '\''\0'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox