From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Ivan Koptelov <ivan.koptelov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: Fixes op-codes' generation for skip-scan
Date: Fri, 4 May 2018 12:50:29 +0300 [thread overview]
Message-ID: <E8C2D170-F2C8-4AC4-8078-B40A3FB6C806@tarantool.org> (raw)
In-Reply-To: <1525421405.73000074@f511.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
> I am confused. 72 chars is a limit for the whole commit
> message?
72 for commit message body, 50 for commit subject.
> I am confused again. What is this 80-chars constraint about?
This is *acceptable* limit of symbols per line in source code.
Notice, that for comments in code it is 66 chars.
Your fix violates this rule: line is about 84 chars.
Also, we are going to support static types soon,
so lets add types for all tests in your suite.
[-- Attachment #2: Type: text/html, Size: 3160 bytes --]
next prev parent reply other threads:[~2018-05-04 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 10:06 [tarantool-patches] " Ivan Koptelov
2018-04-27 11:01 ` [tarantool-patches] " n.pettik
2018-05-04 8:10 ` [tarantool-patches] " Ivan Koptelov
2018-05-04 9:50 ` n.pettik [this message]
2018-05-07 10:42 ` Ivan Koptelov
2018-05-08 16:59 ` n.pettik
2018-05-11 5:28 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E8C2D170-F2C8-4AC4-8078-B40A3FB6C806@tarantool.org \
--to=korablev@tarantool.org \
--cc=ivan.koptelov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: Fixes op-codes'\'' generation for skip-scan' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox