From: "n.pettik" <korablev@tarantool.org>
To: Bulat Niatshin <niatshin@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [patches] [PATCH V2] sql: fix non-working 'INDEXED BY' clause
Date: Thu, 29 Mar 2018 14:28:23 +0300 [thread overview]
Message-ID: <D97F3E71-259A-4793-82DA-76343C027C1D@tarantool.org> (raw)
In-Reply-To: <1522321769.412201095@f369.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
Ack.
> On 29 Mar 2018, at 14:09, Bulat Niatshin <niatshin@tarantool.org> wrote:
>
> 1. You don’t need to invent own wheel: sql-tap already
> has test:do_eqp_test() function.
>
> Done.
>
>
> 2. Why did you divide tests and put them to different test suits?
> > test/sql/gh2966-indexed-by.test.lua
> > test/sql-tap/gh-2996-indexed-by.test.lua
> Put them both to one file to sql-tap/ .
>
> Done.
>
> Branch: https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-by <https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-by>
[-- Attachment #2: Type: text/html, Size: 3185 bytes --]
prev parent reply other threads:[~2018-03-29 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180312112113.10328-1-niatshin@tarantool.org>
[not found] ` <9C7DC5C4-22A8-4F38-8E6A-FACF21115BF2@tarantool.org>
2018-03-29 11:09 ` [tarantool-patches] Re[2]: " Bulat Niatshin
2018-03-29 11:28 ` n.pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D97F3E71-259A-4793-82DA-76343C027C1D@tarantool.org \
--to=korablev@tarantool.org \
--cc=niatshin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [patches] [PATCH V2] sql: fix non-working '\''INDEXED BY'\'' clause' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox