From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove sqlite_ functions from SQL
Date: Tue, 26 Jun 2018 18:17:44 +0300 [thread overview]
Message-ID: <D7CF54A0-A769-4DA9-999D-A26398A2FDEE@tarantool.org> (raw)
In-Reply-To: <bc5989f28ac98fbae1a22172915d49f2c9cb5def.1530020544.git.kyukhin@tarantool.org>
> On 26 Jun 2018, at 16:33, Kirill Yukhin <kyukhin@tarantool.org> wrote:
>
> Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-2184-remove-version
> Issue: https://github.com/tarantool/tarantool/issues/2184
>
> Removed legacy functions: sqlite_version, sqlite_sourceid,
> sqlite_log. Added version built-in function which returns
> Tarantool's version.
>
> Closes #2184
> —
Please, put links to the branch and issue here (after ‘- - -‘).
Also, I have found one mention of sqlite_version():
File: resolve.c, line: 709
/* Date/time functions that use 'now', and other functions like
* sqlite_version() that might change over time cannot be used
* in an index.
*/
Lets remove it as well.
Except for this, LGTM.
next prev parent reply other threads:[~2018-06-26 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:33 [tarantool-patches] " Kirill Yukhin
2018-06-26 15:17 ` n.pettik [this message]
2018-06-29 10:21 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7CF54A0-A769-4DA9-999D-A26398A2FDEE@tarantool.org \
--to=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove sqlite_ functions from SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox