From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: return lookaside system
Date: Mon, 15 Jul 2019 17:42:04 +0300 [thread overview]
Message-ID: <D1E6AAB9-F2C9-4F3D-AD8B-F3B74FF2F881@tarantool.org> (raw)
In-Reply-To: <83b139b9-4268-4f21-c27b-13a2f2da77f3@tarantool.org>
> On 9 Jul 2019, at 12:03, Imeev Mergen <imeevma@tarantool.org> wrote:
>
> Hi! Thank you for review. My answer below.
>
> On 7/8/19 4:13 PM, n.pettik wrote:
>>
>>> On 6 Jul 2019, at 13:23, imeevma@tarantool.org wrote:
>>>
>>> After the removal of the LOOKASIDE system, it was found that the
>>> performance dropped. To restore performance, this patch partially
>>> returns the LOOKASIDE system in almost the same form as it was
>>> before the patch 4326ca7.
>>>
>>> Closes #4319
>> Have you verified that performance is restored by these changes?
>>
> I asked @avtikhon to check this before sending the patch. He
> checked that the performance was restored. Should I copy here the
> tables that he sent me?
I’m ok with this patch. But just in case I would test it with asan/valgrind
(if they are still functioning with Tarantool’s test suite).
prev parent reply other threads:[~2019-07-15 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 10:23 [tarantool-patches] " imeevma
2019-07-08 8:37 ` [tarantool-patches] " Konstantin Osipov
2019-07-08 13:13 ` n.pettik
2019-07-09 9:03 ` Imeev Mergen
2019-07-15 14:42 ` n.pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1E6AAB9-F2C9-4F3D-AD8B-F3B74FF2F881@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: return lookaside system' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox