From: Chris Sosnin <k.sosnin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] app: verify unix socket path length in socket.tcp_server()
Date: Sat, 22 Feb 2020 19:43:12 +0300 [thread overview]
Message-ID: <D014D90B-8FB2-4CF6-8351-9C58363D1C17@tarantool.org> (raw)
In-Reply-To: <df82a30f-6a15-9e08-ef58-c0879be604d5@tarantool.org>
Hi! Thank you for the review!
> 22 февр. 2020 г., в 19:28, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> написал(а):
>
> Hi! Thanks for the patch!
>
>> diff --git a/test/app/socket.result b/test/app/socket.result
>> index 9829df138..f47d06935 100644
>> --- a/test/app/socket.result
>> +++ b/test/app/socket.result
>> @@ -1614,6 +1614,14 @@ socket.getaddrinfo('host', 'port', { flags = 'WRONG' }) == nil and errno() == er
>> ---
>> - true
>> ...
>> +-- gh-4634: verify socket path length in socket.tcp_server.
>> +long_port = string.rep('a', 110)
>> +---
>> +...
>> +socket.tcp_server('unix/', long_port, function(s) end) == errno.ENOBUF
>
> Both function result and errno.ENOBUF are nil. No wonder they are equal.
I’m sorry, I was very careless. The fix is pushed:
+-- gh-4634: verify socket path length in socket.tcp_server.
+long_port = string.rep('a', 110)
+socket.tcp_server('unix/', long_port, function(s) end) == nil and errno() == errno.ENOBUFS
next prev parent reply other threads:[~2020-02-22 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 12:32 Chris Sosnin
2020-02-22 16:28 ` Vladislav Shpilevoy
2020-02-22 16:43 ` Chris Sosnin [this message]
2020-02-23 14:58 ` Vladislav Shpilevoy
2020-02-24 18:18 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D014D90B-8FB2-4CF6-8351-9C58363D1C17@tarantool.org \
--to=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] app: verify unix socket path length in socket.tcp_server()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox