Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>,
	Alex Khatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: fix typo in MakeRecord memory hint
Date: Mon, 1 Oct 2018 03:12:34 +0300	[thread overview]
Message-ID: <CE1B3A26-10AF-44A8-877D-8FDDCE99E800@tarantool.org> (raw)
In-Reply-To: <a5576aa77bf900d0ceae126ba46a80c56078df6c.1538051558.git.avkhatskevich@tarantool.org>

LGTM.

> On 27 Sep 2018, at 15:39, AKhatskevich <avkhatskevich@tarantool.org> wrote:
> 
> Part of: #2181
> Related to: #3021
> ---
> Issue: https://github.com/tarantool/tarantool/issues/3021
> 
> src/box/sql/update.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/box/sql/update.c b/src/box/sql/update.c
> index 730872fc6..1069f62cb 100644
> --- a/src/box/sql/update.c
> +++ b/src/box/sql/update.c
> @@ -276,9 +276,9 @@ sqlite3Update(Parse * pParse,		/* The parser context */
> 								pPk->def);
> 		sqlite3VdbeAddOp4(v, OP_MakeRecord, iPk, pk_part_count,
> 				  regKey, zAff, pk_part_count);
> -		sqlite3VdbeAddOp2(v, OP_IdxInsert, iEph, regKey);
> 		/* Set flag to save memory allocating one by malloc. */
> 		sqlite3VdbeChangeP5(v, 1);
> +		sqlite3VdbeAddOp2(v, OP_IdxInsert, iEph, regKey);
> 	}
> 	/* End the database scan loop.
> 	 */
> --

  reply	other threads:[~2018-10-01  0:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 12:39 [tarantool-patches] [PATCH 0/2] Add test on changes && fix typo in MakeRecord AKhatskevich
2018-09-27 12:39 ` [tarantool-patches] [PATCH 1/2] sql: fix typo in MakeRecord memory hint AKhatskevich
2018-10-01  0:12   ` n.pettik [this message]
2018-09-27 12:39 ` [tarantool-patches] [PATCH 2/2] sql: add test on changes/total_changes AKhatskevich
2018-09-30 23:54   ` [tarantool-patches] " n.pettik
     [not found]     ` <c5639a4e-0b51-cbaa-112c-4f47d86bbe07@tarantool.org>
2018-10-01 15:20       ` n.pettik
2018-10-01 16:13         ` Alex Khatskevich
     [not found]           ` <881CB143-0DC2-468A-90CA-0459E9EE7B15@gmail.com>
2018-10-04 10:49             ` n.pettik
     [not found]               ` <75020feb-3d2a-2707-bfdb-fd3fd2229afa@tarantool.org>
2018-10-09 12:11                 ` n.pettik
2018-10-10 14:39                   ` Alex Khatskevich
2018-10-18 14:41                     ` n.pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE1B3A26-10AF-44A8-877D-8FDDCE99E800@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=avkhatskevich@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 1/2] sql: fix typo in MakeRecord memory hint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox