Re: [Tarantool-patches] [PATCH 00/11] Enable miscelaneous sanitations

[Cyrill Gorcunov <gorcunov@gmail.com>]

lgtm

On Fri, Jun 5, 2020 at 2:43 AM Vladislav Shpilevoy
<v.shpilevoy@tarantool.org> wrote:
>
> The patchset is a second part of the undefined behaviour fixes. It
> is based on the UB alignment patchset, and enables all the other
> UB checks except a few last ones, described in the first commit.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4609-sanitize-misc-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4609
>
> Aleksandr Lyapunov (1):
>   salad: fix UB pointer arithmetics in bps_tree
>
> Vladislav Shpilevoy (10):
>   cmake: enable misc types of UB detection in clang
>   util: introduce double_compare_nint64()
>   test: avoid usleep() usage for error injections
>   vinyl: fix 0 division in case of canceled dump
>   xrow: don't cast double to float unconditionally
>   swim: fix zero division
>   test: fix signed integer overflow in vclock test
>   digest: eliminate UBs from guava()
>   sql: fix usage of not initialized index_stat
>   sql: fix mem_apply_type double type truncation
>
>  cmake/compiler.cmake        | 16 ++++++++++++++-
>  src/box/sql/vdbe.c          | 18 +++++++++++------
>  src/box/sql/vdbeaux.c       | 16 +++++++--------
>  src/box/sql/where.c         |  4 ++--
>  src/box/tuple_compare.cc    |  9 ++-------
>  src/box/vy_regulator.c      | 10 ++++++----
>  src/box/vy_run.c            |  2 +-
>  src/box/vy_scheduler.c      |  2 +-
>  src/box/xrow_update_field.c | 19 +++++++++---------
>  src/lib/core/util.c         | 39 ++++++++++++++++++++++++++++++++++++-
>  src/lib/salad/bps_tree.h    | 14 ++++++-------
>  src/lib/salad/guava.c       | 18 ++++++++++-------
>  src/lib/salad/guava.h       |  2 +-
>  src/lib/swim/swim.c         | 10 +++++-----
>  src/lua/digest.lua          |  2 +-
>  src/trivia/util.h           | 29 +++++++++++++++++++++++++++
>  test/app/digest.result      |  2 +-
>  test/box/update.result      |  2 +-
>  test/box/update.test.lua    |  2 +-
>  test/unit/vclock.cc         | 28 +++++++++++++-------------
>  test/unit/vclock.result     |  2 +-
>  21 files changed, 167 insertions(+), 79 deletions(-)
>
> --
> 2.21.1 (Apple Git-122.3)
>