Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt

[Mavr Huston <huston.mavr@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

Thanks!
I've marked it as follow up for #2971 at commit message.

пн, 15 июн. 2020 г. в 00:35, Alexander Turenko <
alexander.turenko@tarantool.org>:

> LGTM.
>
> Vlad, can you look at the patch?
>
> WBR, Alexander Turenko.
>
> On Thu, Jun 11, 2020 at 03:25:10AM +0300, HustonMmmavr wrote:
> > Removed definition and initialization of EXPORT_LIST variable at file
> > src/CMakeLists.txt. After patch 03790ac551 this variable is unused
> > (no reference to this variable after its initialization can be found
> > in whole project) and it is only misleading.
> >
> > Closes #5066
>
> I would also mark it as follow up for #2971.
>
> > ---
> > I've builded tarantool before applying this changes and after.
> > Then I've checked difference in tarantool binary file symbols with
> > nm and diff commands and there was no difference.
> >
> > Issue: https://github.com/tarantool/tarantool/issues/5066
> > Branch:
> https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete-unusued-export-list
> >
> > @ChangeLog
> > - Cleanup src/CMakeLists.txt (gh-5066)
>
> This change is not visible for a user, so I would not add a changelog
> entry for it.
>

[-- Attachment #2: Type: text/html, Size: 1848 bytes --]