From: Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance in postinstall
Date: Mon, 8 Jun 2020 15:46:10 +0300 [thread overview]
Message-ID: <CAK0MaD3cUPnHYptc1N2DX6x0-U4Cmfb7rt6cYJO36mZRk4PZZA@mail.gmail.com> (raw)
In-Reply-To: <20200605065521.i3k3dw7xmsejdysm@tkn_work_nb>
[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]
Hi!
As a person who "faced the issue for several times across these years" I
can only add
that that most important is fresh installatoin. As far as I can see,
the original
patch
<https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016443.html>
is enough
to solve the problem. So, LGTM.
P.S. I won't comment other parts of discussion because they're beyond my
understanding of deb scripts.
On Fri, 5 Jun 2020 at 09:55, Alexander Turenko <
alexander.turenko@tarantool.org> wrote:
> > Long story short: comparing both approaches I personally prefer to apply
> > the one from the origin patch and take some changes you provided below
> > (e.g. empty <enabled> directory handling).
> >
> > I also Cced Yaroslav as the person who faced the issue "for several
> > times across these years".
>
> I don't mind any of these approaches. I don't know which one would be
> better. So I would say that I have no preference for one over another.
>
> > AFAICS, there are some files left on the system after this "migration"
> > that are not tracked by the package. So they are not removed anymore
> > even after the package is deinstalled.
>
> They will not be removed at `apt-get remove`, but will be at `apt-get
> purge` as well as everything in /etc/tarantool. See:
>
> | $ cat debian/tarantool-common.postrm
> | #!/bin/sh
> |
> | set -e
> |
> | case "$1" in
> | purge)
> | rm -fr \
> | /etc/tarantool \
> | /var/log/tarantool \
> | /var/run/tarantool \
> | /var/lib/tarantool
> | ;;
> | esac
> |
> | #DEBHELPER#
>
--
С уважением.
Дынников Ярослав.
[-- Attachment #2: Type: text/html, Size: 2441 bytes --]
prev parent reply other threads:[~2020-06-08 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 12:20 Olga Arkhangelskaia
2020-05-25 13:03 ` Igor Munkin
2020-05-25 16:27 ` Olga Arkhangelskaia
2020-05-26 15:09 ` Oleg Babin
2020-05-26 16:00 ` Igor Munkin
2020-05-27 10:04 ` Olga Arkhangelskaia
2020-05-27 16:02 ` Alexander Turenko
2020-05-28 9:28 ` Olga Arkhangelskaia
2020-05-28 11:33 ` Olga Arkhangelskaia
2020-06-04 21:51 ` Igor Munkin
2020-06-05 6:55 ` Alexander Turenko
2020-06-08 12:46 ` Yaroslav Dynnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK0MaD3cUPnHYptc1N2DX6x0-U4Cmfb7rt6cYJO36mZRk4PZZA@mail.gmail.com \
--to=yaroslav.dynnikov@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] core: don'\''t start example instance in postinstall' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox