Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl

[Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 3351 bytes --]

Hi, guys.

Recently we talked to Leonid in chat and discussed the necessity of
removing flags. I've offered Leonid to check behavior, so here is what
I've found.

My point of view (now and then) is that they're neither useful nor
harmful. Earlier I did agree to blacklist them, but looking at Leonids
patch set this week I've changed my mind as the second commit seems
just worthless to me.

Inline help says:

```
--lua-dir=<prefix>     Which Lua installation to use.
--lua-version=<ver>    Which Lua version to use.
--global               Use the system tree when `local_by_default` is
`true`.
--local                Use the tree in the user's home directory.
                       To enable it, see
'/opt/tarantool-install/bin/tarantoolctl help path'.

Rocks trees in use:
        /tmp/tmp.JY1fgy8La9/.rocks ("user")
        /opt/tarantool-install ("system")
```

* Tarantool does define `LOCAL_BY_DEFAULT = true`,
  (i.e. `--local` is our default behavior)

* "System tree" is the place where tarantool is installed
  (`-DCMAKE_INSTALL_PREFIX`).

* "Home directory" in tarantool is overriden with `./.rocks`.

* See "rocks: update luarocks to 3.1.1" 4222c1f6
<https://github.com/tarantool/tarantool/commit/4222c1f6451973f446f9c8be28c7012435416fa3>
.

* Both `--local` and `--global` are only shortcuts for predefined
  `--tree=<tree>`, which isn't going to be removed.

* Speaking of `--lua-dir` and `--lua-version`, they look to be neither
  useful nor harmful.

Please, notice that command-line help refers to `tarantoolctl help
path`, but

1. It should be `tarantoolctl rocks help` (I guess there are many of
   such places)
2. `rocks path` command is disabled in your patch.

I'm a lazy developer and I don't like unnecessary restrictions. If I
were you, I'd drop the second commit ("Delete flags which can't be used
with tarantoolctl rocks" 1b51b2f) and enable back `rocks path` command.
Let people decide whether they need it or not.

Finally, a few words about documentation. I've tried to write down all
supported commands and flags, and I found it's really difficult and
verbose. I'm withdrawing my suggestion to clarify it, I don't know what
to do. Perhaps, documentation should just refer to inline help, as it's the
only up-to-date information, and still correct enough.



On Sun, 12 Apr 2020 at 20:25, lvasiliev <lvasiliev@tarantool.org> wrote:

>
>
> On 11.04.2020 17:23, Vladislav Shpilevoy wrote:
>
> >> As of the second one ("Delete flags which can't be used with
> >> tarantoolctl rocks" 1b51b2f <
> https://github.com/tarantool/luarocks/commit/1b51b2fe1c194719a7a8a74220a954a91c21f2a7>),
> I'm worried that our fork every day goes
> >> farther from upstream. You didn't say a word about necessity to /remove/
> >> it, but it looks like another postponed problem.
> >
> > Leonid, btw, why do we remove them, again? I was always thinking it
> > is a part of the ticket, but I don't see it there except in your
> > comments.
> Because after talking with Yaroslav, we decided that the user should not
> be able to use these flags.
> When I worked on task, I was still too young and did not know that all
> summaries of discussions should be written down in comments on task.
>


-- 
С уважением.
Дынников Ярослав.

[-- Attachment #2: Type: text/html, Size: 4413 bytes --]