From: Nikita Tatunov <hollow653@gmail.com>
To: korablev@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: xfer optimization issue
Date: Fri, 20 Jul 2018 19:58:48 +0300 [thread overview]
Message-ID: <CAEi+_ap4Lc5QBPExitzSt_ZDMbF3ea=iqXFLGXDvwV+rY1MQ=Q@mail.gmail.com> (raw)
In-Reply-To: <2123605D-8D6C-43A3-846F-735E4C2C7FC2@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
Ooops. Thank you! fixed it and pushed.
пт, 20 июл. 2018 г. в 19:43, n.pettik <korablev@tarantool.org>:
> LGTM.
>
> diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c
> index 3c3bf37..4f52fa5 100644
> --- a/src/box/sql/insert.c
> +++ b/src/box/sql/insert.c
> @@ -1869,7 +1869,7 @@ xferOptimization(Parse * pParse, /* Parser context
> */
> * table (tab1) is initially empty.
> */
>
> - /* The Vdbe we're building*/
> + /* The Vdbe struct we're building. */
>
>
> You misunderstood me. What I mean is:
>
> struct Vibe *v = …;
>
> Vdbe *v = sqlite3GetVdbe(pParse);
>
>
>
[-- Attachment #2: Type: text/html, Size: 2057 bytes --]
next prev parent reply other threads:[~2018-07-20 16:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 15:32 [tarantool-patches] " N.Tatunov
2018-04-18 16:33 ` [tarantool-patches] " Hollow111
2018-04-19 11:22 ` n.pettik
2018-04-19 15:36 ` Hollow111
2018-04-20 1:02 ` n.pettik
2018-04-20 15:09 ` Hollow111
2018-04-20 16:09 ` n.pettik
2018-04-20 17:59 ` Hollow111
2018-04-23 23:40 ` n.pettik
2018-04-27 15:45 ` Hollow111
2018-05-03 22:57 ` n.pettik
2018-05-04 12:54 ` Hollow111
2018-06-28 10:18 ` Alexander Turenko
2018-07-09 15:50 ` Alexander Turenko
2018-07-16 12:54 ` Nikita Tatunov
2018-07-16 13:06 ` n.pettik
2018-07-16 13:20 ` Nikita Tatunov
2018-07-16 18:37 ` Nikita Tatunov
2018-07-16 19:12 ` n.pettik
2018-07-16 21:27 ` Nikita Tatunov
2018-07-18 15:13 ` n.pettik
2018-07-18 20:18 ` Nikita Tatunov
2018-07-19 0:20 ` n.pettik
2018-07-19 17:26 ` Nikita Tatunov
2018-07-20 3:20 ` n.pettik
2018-07-20 11:56 ` Nikita Tatunov
2018-07-20 16:43 ` n.pettik
2018-07-20 16:58 ` Nikita Tatunov [this message]
2018-07-29 1:12 ` Alexander Turenko
2018-07-29 11:23 ` n.pettik
2018-07-29 15:16 ` Alexander Turenko
2018-07-30 18:33 ` Nikita Tatunov
2018-07-30 22:17 ` Alexander Turenko
2018-07-31 11:48 ` Nikita Tatunov
2018-07-31 13:29 ` Alexander Turenko
2018-07-31 17:04 ` Nikita Tatunov
2018-07-31 17:44 ` Alexander Turenko
2018-08-21 16:43 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEi+_ap4Lc5QBPExitzSt_ZDMbF3ea=iqXFLGXDvwV+rY1MQ=Q@mail.gmail.com' \
--to=hollow653@gmail.com \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: xfer optimization issue' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox