From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Roman Khabibov <roman.habibov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove unused mask
Date: Fri, 9 Aug 2019 18:46:54 +0300 [thread overview]
Message-ID: <C7B7DBF0-8141-4438-B280-DABAD2BCCA99@tarantool.org> (raw)
In-Reply-To: <20190802124629.54302-1-roman.habibov@tarantool.org>
> On 2 Aug 2019, at 15:46, Roman Khabibov <roman.habibov@tarantool.org> wrote:
>
> Field mask of "struct Keyword" is always set to one not null
> macroses and used only once for checking that it isn't null. So,
> the field should be removed.
>
> Closes #4155
I’ve fixed commit message and force pushed.
sql: remove mask from struct Keyword
Originally, mask in struct Keyword served to reduce set of reserved
keywords for build-dependent features. For instance, it was allowed to
disable triggers as a compilation option, and in this case TRIGGER
wouldn't be reserved word. Nowadays, our build always comprises all
features, so there's no need in this option anymore. Hence, we can
remove mask alongside with related to it macros.
Closes #4155
The rest is OK as obvious.
next prev parent reply other threads:[~2019-08-09 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 12:46 [tarantool-patches] " Roman Khabibov
2019-08-09 15:46 ` n.pettik [this message]
2019-08-14 14:35 ` [tarantool-patches] " Roman Khabibov
2019-08-14 20:48 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7B7DBF0-8141-4438-B280-DABAD2BCCA99@tarantool.org \
--to=korablev@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove unused mask' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox