Re: [tarantool-patches] [PATCH] Extend range of printable unicode characters

[Serge Petrenko <sergepetrenko@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]





> 16 июля 2019 г., в 21:31, Konstantin Osipov <kostja@tarantool.org> написал(а):
> 
> * Serge Petrenko <sergepetrenko@tarantool.org> [19/07/16 16:44]:
>> Before the patch IS_PRINTABLE macros was used
>> to determine if given character is printable or not.
>> This macros did not take into account characters
>> encoded with 4 bytes.
>> After the patch IS_PRINTABLE is replaced with new
>> corresponding function. Now the range of printable
>> characters is: (libyaml old range) U (icu range). This
>> new range include characters encoded with 4 bytes.
>> 
> 
> Please don't forget to upstream the patch to the maintainer once
> it's reviewed.

Ok

> 
> Has there been any changes in the upstream which we should be
> aware of?

None that I’m aware of.
Similar issues are still open in the libyaml repo.
https://github.com/yaml/libyaml/issues/110 <https://github.com/yaml/libyaml/issues/110>
The code dealing with printable unicode characters in libyaml
remains the same, it doesn’t deal with codepoints outside of
the Basic Multilingual Plane (every code point > 0xFFFF)
https://github.com/yaml/libyaml/blob/master/src/yaml_private.h#L261



> 
> On another note, since we're switching to Lua emitter as the
> defualt one quite soon, we can perhaps close #4090 as won't fix
> rather than bother improving libyaml.
> 
>> Related to tarantool/tarantool#4090
> 
> -- 
> Konstantin Osipov, Moscow, Russia

--
Serge Petrenko
sergepetrenko@tarantool.org



[-- Attachment #2: Type: text/html, Size: 3112 bytes --]