From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: fix boolean variables binding
Date: Thu, 25 Apr 2019 17:52:37 +0300 [thread overview]
Message-ID: <BE557D96-5CBC-4AAE-A41A-209A608EFE52@tarantool.org> (raw)
In-Reply-To: <b4869e842a8dbdb0cc5a1d68415f7f50d69dea41.1556200796.git.kshcherbatov@tarantool.org>
> diff --git a/src/box/bind.c b/src/box/bind.c
> index 5aa79751a..b01ad4a74 100644
> --- a/src/box/bind.c
> +++ b/src/box/bind.c
> @@ -98,8 +98,7 @@ sql_bind_decode(struct sql_bind *bind, int i, const char **packet)
> bind->bytes = 1;
> break;
> case MP_BOOL:
> - /* sql doesn't support boolean. Use int instead. */
> - bind->i64 = mp_decode_bool(packet) ? 1 : 0;
> + bind->b = mp_decode_bool(packet);
> bind->bytes = sizeof(bind->i64);
sizeof(bind->b);
The rest is OK as obvious.
next prev parent reply other threads:[~2019-04-25 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 14:00 [tarantool-patches] " Kirill Shcherbatov
2019-04-25 14:52 ` n.pettik [this message]
2019-04-25 14:54 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-26 10:37 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE557D96-5CBC-4AAE-A41A-209A608EFE52@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: fix boolean variables binding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox