Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: roman.habibov1@yandex.ru
Subject: [tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and  CREATE TEMPORARY TABLE
Date: Tue, 8 May 2018 13:30:38 +0300	[thread overview]
Message-ID: <BB1D3105-6F9A-445C-9675-F9A172F79737@tarantool.org> (raw)
In-Reply-To: <aae0bec697872f421cf229b02ae3fc5f93a2b24e.1525474833.git.roman.habibov1@yandex.ru>

 Hello, Roman.

Firstly, please specify subject of commit. In your particular case,
test definitely belongs to SQL part of project, so it is better to write
'sql: Tests for CREATE TEMP TABLE and  CREATE TEMPORARY TABLE'.
Notice, that commit subject should fit into 50 chars lenght.
Read this guide: https://tarantool.io/en/doc/2.0/dev_guide/developer_guidelines.html#how-to-write-a-commit-message

Secondly, after '---' delimiter (which separates commit message and
body of the patch) put link to your branch and corresponding issue.
Read this: https://tarantool.io/en/doc/2.0/dev_guide/developer_guidelines.html#how-to-submit-a-patch-for-review

Then, don't spam with commits. If you are willing to update your remote
branch with new version of the same code, use 'force' option:
git push -f. As for your patch, it must consist of only 1 commit.
Please, update your branch so than I can take a loot at whole patch.

>+-- gh-2166 Functions with TEMP and TEMPORARY was removed before.

Typo: ‘were’. And not functions, but tables themselves, I guess.

  parent reply	other threads:[~2018-05-08 10:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05 22:34 [tarantool-patches] " Roman Khabibov
2018-05-07 13:08 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-07 18:50   ` roman.habibov1
2018-05-07 23:12     ` Vladislav Shpilevoy
2018-05-07 23:30       ` roman.habibov1
2018-05-08  8:15         ` Vladislav Shpilevoy
2018-05-08 10:30 ` n.pettik [this message]
     [not found]   ` <2050311525824390@web59j.yandex.ru>
2018-05-09 14:30     ` [tarantool-patches] Re: [PATCH v1 1/1] sql: " n.pettik
2018-05-09 17:20       ` roman.habibov1
2018-05-11 13:12         ` n.pettik
2018-05-11 15:18           ` [tarantool-patches] Re: [PATCH v1 1/1] sql: added tests for TEMP and TEMPORARY clauses roman.habibov1
2018-05-14 14:50             ` n.pettik
2018-05-18 23:44               ` roman.habibov1
2018-05-19  0:28                 ` n.pettik
2018-05-19 11:57                   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BB1D3105-6F9A-445C-9675-F9A172F79737@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=roman.habibov1@yandex.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and  CREATE TEMPORARY TABLE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox