From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: remove SQL_*_BKPT macros
Date: Tue, 26 Feb 2019 21:12:49 +0300 [thread overview]
Message-ID: <BA6EB4E5-B6C7-4628-8D07-96945A6E98E3@tarantool.org> (raw)
In-Reply-To: <efdf9612620d7f1741bbe0a5c3ff585dbcb269dc.1551192665.git.imeevma@gmail.com>
> On 26 Feb 2019, at 17:52, imeevma@tarantool.org wrote:
>
> Macros SQL_*_BKPT were used in debug mode to log errors that
> occurred during the execution of VDBE. They are not used now.
> This patch removes them.
>
> Part of #3965
> ---
> https://github.com/tarantool/tarantool/issues/3965
> https://github.com/tarantool/tarantool/tree/imeevma/gh-3965-rework-errors-in-vdbe
>
>
> @@ -652,7 +652,7 @@ sql_progress_handler(sql * db,
> {
> #ifdef SQL_ENABLE_API_ARMOR
> if (!sqlSafetyCheckOk(db)) {
> - (void)SQL_MISUSE_BKPT;
> + (void)SQL_MISUSE;
I’ve removed things like this and pushed updated branch.
LGTM.
next prev parent reply other threads:[~2019-02-26 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:52 [tarantool-patches] " imeevma
2019-02-26 18:12 ` n.pettik [this message]
2019-02-27 11:17 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BA6EB4E5-B6C7-4628-8D07-96945A6E98E3@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: remove SQL_*_BKPT macros' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox